Closed Bug 1444400 Opened 6 years ago Closed 6 years ago

Don't use a string HTML template in completer.js

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Version:
60 Branch
Type:
enhancement

Tracking

(firefox60 affected)

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox60 --- affected

People

(Reporter: johannh, Unassigned)

References

Details

In completer.js we're inserting raw markup from the completerHTML string using unsafeSetInnerHTML (see bug 1444395): https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/devtools/shared/gcli/source/lib/gcli/mozui/completer.js#72

We should just build the DOM using JS.
Not going to happen, we're just removing the code.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.