Remove unsafeSetInnerHTML in config.js

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: johannh, Assigned: johannh)

Tracking

unspecified
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Fennec's about:config is using the unsafeSetInnerHTML function to inject an HTML string, which looks pretty unnecessary to me and can probably just be converted to plain JS (which should also make it faster).

https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/mobile/android/chrome/content/config.js#609
Blocks: 1444394
No longer blocks: 1444395
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Attachment #8967713 - Flags: review?(gijskruitbosch+bugs) → review?(cnevinchen)
This needs a fennec peer's review.
Comment on attachment 8967713 [details]
Bug 1444428 - Remove unsafeSetInnerHTML in config.js.

https://reviewboard.mozilla.org/r/236430/#review242512
Attachment #8967713 - Flags: review?(cnevinchen) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8acb65ad7377
Remove unsafeSetInnerHTML in config.js. r=nechen
https://hg.mozilla.org/mozilla-central/rev/8acb65ad7377
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.