Closed
Bug 1444428
Opened 6 years ago
Closed 6 years ago
Remove unsafeSetInnerHTML in config.js
Categories
(Firefox for Android Graveyard :: General, enhancement, P3)
Firefox for Android Graveyard
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: johannh, Assigned: johannh)
References
Details
Attachments
(1 file)
Fennec's about:config is using the unsafeSetInnerHTML function to inject an HTML string, which looks pretty unnecessary to me and can probably just be converted to plain JS (which should also make it faster). https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/mobile/android/chrome/content/config.js#609
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8967713 -
Flags: review?(gijskruitbosch+bugs) → review?(cnevinchen)
Comment 2•6 years ago
|
||
This needs a fennec peer's review.
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8967713 [details] Bug 1444428 - Remove unsafeSetInnerHTML in config.js. https://reviewboard.mozilla.org/r/236430/#review242512
Attachment #8967713 -
Flags: review?(cnevinchen) → review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8acb65ad7377 Remove unsafeSetInnerHTML in config.js. r=nechen
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8acb65ad7377
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•