1444456 - contentScripts.register JSON API schema should not use "additionalProperties"

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The JSON API Schema definition of the contentScripts.register API method currently contains an "additionalProperties" set to "UnrecognizedProperty", but "additionalProperties" should not be used for this API method, it was part of the content script options for the manifest (where it makes sense to allow unknown properties to just raise a warning instead of an error during the addon installation) and it has been part of the contentScripts.register definition by mistake.

The "additionalProperties" is not actually allowing any additional property to the contentScripts.register API method (because the "UnrecognizedProperty" ref can't be resolved, because it is actually definied inside the manifest namespace) but it is producing the wrong error message ("Internal error: Type UnrecognizedProperty not found" instead of the expected "Type error for parameter contentScriptOptions (Unexpected property \\"unknownParam\\") for contentScripts.register" error message).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1444456 - Fix contentScripts.register API schema should not use additionalProperties.

Review commit: https://reviewboard.mozilla.org/r/226502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226502/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8957611 [details]
Bug 1444456 - Fix contentScripts.register API schema should not use additionalProperties.

https://reviewboard.mozilla.org/r/226502/#review232398

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8957611 [details]
Bug 1444456 - Fix contentScripts.register API schema should not use additionalProperties.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226502/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9604e2f313f
Fix contentScripts.register API schema should not use additionalProperties. r=mixedpuppy

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d9604e2f313f