1444475 - Bump the mozilla eslint plugin version to update folks with the changes from bug 1434869

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Dave Townsend [:mossop]]

Bug 1434869 didn't update the mozilla eslint plugin version so mach doesn't notice it has to update their plugin and so lint checks start failing.

Comment 1

[Mark Banner (:standard8)]

node_modules/eslint-plugin-mozilla should have been created as a symlink to tools/lint/eslint/eslint-plugin-mozilla, so that the module automatically gets the new changes as the source repository is updated.

As far as I know, all versions of npm that come with node 6.9.1 or later (i.e. npm 3.10.8 or later), support symlinks. I believe even earlier versions did as well.

When we did the ESLint 4 bump a month or two back, we also nuked the node_modules directory & re-installed it, so any issues should have been resolved automatically.

We actually removed the version detection code for the eslint-plugin-mozilla/spidermonkey modules quite a while ago as we didn't need it any more with the symlinks.


Andrew, with that information, can you provide a bit more detail about the issues you saw please?

Comment 2

[Andrew Swan [:aswan]]

I got bit by this.  I'm on MacOS, I probably did something wrong in getting node and/or npm installed.  I think that ages ago I used the installer from nodejs.com but more recently I tried to uninstall that in favor of node installed with homebrew.  In any case, at this moment I have a Frankenstein setup with node 9.7.1 installed via homebrew and npm 5.6.0 installed from i-have-no-idea-where...

Comment 3

[Andrew Swan [:aswan]]

Welp, when I encountered this this morning, node_modules/eslint-plugin-mozilla was not a symlink but a stale copy of tools/lint/eslint/eslint-plugin-mozilla/  I "fixed" it by rm'ing node_modules/eslint-plugin-mozilla and now it is a symlink...

Comment 4

[Mark Banner (:standard8)]

(In reply to Andrew Swan [:aswan] from comment #2)
> In any case, at this moment I have a Frankenstein
> setup with node 9.7.1 installed via homebrew and npm 5.6.0 installed from
> i-have-no-idea-where...

Homebrew installs npm alongside node. If you want the 8.x series, you can uninstall `node` and install `node@8`, though it really shouldn't matter if you're on the 9.x series wrt ESLint.

Comment 5

[Mark Banner (:standard8)]

My only thought is maybe you had tried installing it manually at some stage in the past. Unless there was some other weird issue that caused it to be a non-symlink.

Comment 6

[Andrew Swan [:aswan]]

If "it" means the eslint plugin, I'm pretty sure I never did that.

Comment 7

[Mark Banner (:standard8)]

My best guess here is that something had gone wrong a while before this happened and messed things up. We had a few reports at the time, but nothing recently.

I'm going to tentatively mark this as WFM.