Closed Bug 1444481 Opened 2 years ago Closed 2 years ago

Misc. #include cleanup in layout/style

Categories

(Core :: CSS Parsing and Computation, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(4 files)

I noticed a few unnecessary/missing #includes in layout/style yesterday -- filing this bug to cover some misc. cleanup there.

Patches coming shortly.
Here's a helper patch that I based my work on top of here. This disables unified builds in layout/style as much as we can (2 files have to be unified right now -- see bug 1437727).

This patch isn't part of what I'll be landing here, but I used it locally to be sure I'm not removing headers that we actually need.
Priority: -- → P5
Comment on attachment 8957646 [details]
Bug 1444481 part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h.

https://reviewboard.mozilla.org/r/226524/#review232492
Attachment #8957646 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8957647 [details]
Bug 1444481 part 2: Replace unneeded #includes in nsStyleConsts.h with more specific ones (and add missing headers to nsStyleCoord.h).

https://reviewboard.mozilla.org/r/226526/#review232494
Attachment #8957647 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8957648 [details]
Bug 1444481 part 3: #include nsStringFwd.h rather than nsString.h in some layout/style headers.

https://reviewboard.mozilla.org/r/226528/#review232498
Attachment #8957648 - Flags: review?(xidorn+moz) → review+
Thanks for the review!
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37e3ec770550
part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/54aa980d30f7
part 2: Replace unneeded #includes in nsStyleConsts.h with more specific ones (and add missing headers to nsStyleCoord.h). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/14f77d01522b
part 3: #include nsStringFwd.h rather than nsString.h in some layout/style headers. r=xidorn
You need to log in before you can comment on or make changes to this bug.