Closed
Bug 1444499
Opened 5 years ago
Closed 5 years ago
Update pdf.js to version 2.0.447
Categories
(Firefox :: PDF Viewer, task)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
Firefox 61
People
(Reporter: RyanVM, Assigned: bdahl)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1442785 +++ Changes since last update: #9493 [api-major] Move the remaining options from, and completely remove, the global `PDFJS` object #9508 Add paper size to document information/properties #9509 Implement a single `getInheritableProperty` utility function #9542 [CRX] Fix error that broke the Chrome extension
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6405d9287056 Update pdf.js to version 2.0.426. r=bdahl
Backout by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/55dedf58f123 Backed out changeset 6405d9287056 for failing browser chrome at browser/extensions/pdfjs/test/browser_pdfjs_main.js on a CLOSED TREE
Reporter | ||
Comment 3•5 years ago
|
||
From IRC discussion, it sounds like bdahl is working on the test bustage.
Flags: needinfo?(bdahl)
Reporter | ||
Comment 4•5 years ago
|
||
IIUC, this is blocked on upstream issue #9545.
status-firefox61:
--- → affected
See Also: → https://github.com/mozilla/pdf.js/issues/9545
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•5 years ago
|
||
mozreview-review |
Comment on attachment 8960825 [details] Bug 1444499 - Update pdf.js to version 2.0.447. https://reviewboard.mozilla.org/r/229566/#review235294 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: browser/extensions/pdfjs/content/PdfJsDefaultPreferences.jsm:41 (Diff revision 1) > + "renderer": "canvas", > + "renderInteractiveForms": false, > + "enablePrintAutoRotate": false, > + "disablePageMode": false, > + "disablePageLabels": false > +}); Error: Newline required at end of file but not found. [eslint: eol-last]
Comment hidden (mozreview-request) |
Reporter | ||
Updated•5 years ago
|
Summary: Update pdf.js to version 2.0.426 → Update pdf.js to version 2.0.447
Reporter | ||
Comment 9•5 years ago
|
||
For perpetuity, additional changes from 426->447: #9541 [CRX] Disable fetch in Chrome 60- #9549 Attempt to handle corrupt PDF documents that inline Page dictionaries in a Kids array (issue 9540) #9574 Update translations #9577 [api-minor] Fix various issues related to pageSize, and display the size for the active page in the document properties dialog #9571 [Firefox addon] Refactor bundling of the `default_preferences.json` file #9587 Move the `cursorToolOnLoad` preference handling into `AppOptions` (PR 9493 follow-up) #9565 Rename the globals to shorter names. #9584 Update examples/ documentation for 2.0
Flags: needinfo?(bdahl)
Reporter | ||
Updated•5 years ago
|
Assignee: ryanvm → bdahl
Reporter | ||
Comment 10•5 years ago
|
||
Yury, any chance you'll be able to look at these reviews sometime soon? :)
Flags: needinfo?(ydelendik)
Comment 11•5 years ago
|
||
mozreview-review |
Comment on attachment 8960824 [details] Bug 1444499 - Remove checks for global PDFJS. https://reviewboard.mozilla.org/r/229564/#review237044
Attachment #8960824 -
Flags: review?(ydelendik) → review+
Comment 12•5 years ago
|
||
mozreview-review |
Comment on attachment 8960825 [details] Bug 1444499 - Update pdf.js to version 2.0.447. https://reviewboard.mozilla.org/r/229566/#review237048 Looks good.
Attachment #8960825 -
Flags: review?(ydelendik) → review+
Comment 13•5 years ago
|
||
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/974e81a794a1 Remove checks for global PDFJS. r=yury https://hg.mozilla.org/integration/autoland/rev/7d8a99f5f759 Update pdf.js to version 2.0.447. r=yury
Comment 14•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/974e81a794a1 https://hg.mozilla.org/mozilla-central/rev/7d8a99f5f759
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Reporter | ||
Updated•4 years ago
|
Flags: needinfo?(ydelendik)
Reporter | ||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•