1444508 - Convolver with mono response produces stereo output

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.124 Safari/537.36

Steps to reproduce:

Look at https://wpt.fyi/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade.html and https://wpt.fyi/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html.

The first has a convolver both with mono responses and the first has a mono source.  This should result in a non-zero output.

The second is similar, testing sources with various number of channels for the input and a mono convolver.

The spec on convolver nodes was tightened up a few months ago, and I think Firefox hasn't gotten around to fixing them.  These diagrams are relevant: https://webaudio.github.io/web-audio-api/#Convolution-channel-configurations


Actual results:

The tests fail


Expected results:

The tests pass

Comment 1

[ovidiu boca[:Ovidiu]]

I visited https://w3c-test.org/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade.html and I can reproduce this on Mac Os X 10.12, Windows 10 with FF Nightly 61.0a1(2018-03-13) and FF 59 release. 
Andreas can you please take a look at this, I think is a WebRTC issue.

Comment 2

[Andreas Pehrson [:pehrsons]]

Looks like web audio to me.

Comment 3

[Paul Adenot (:padenot)]

Yes. Thanks Raymond, we've not come to this one just yet.

Comment 4

[Karl Tomlinson (:karlt)]

Thank you for reporting. This should have been fixed in bug 1474222, but the convolver-cascade.html expected results need updating.

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1444508 remove obsolete expected failures r?padenot

These have been lingering since
https://hg.mozilla.org/mozilla-central/rev/3ac736416349
due to bug 1474463.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c6601b33cbe
remove obsolete expected failures r=padenot

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4c6601b33cbe