Closed Bug 1444554 Opened 4 years ago Closed 4 years ago

Telemetry measures for browser error collection


(Firefox :: General, enhancement, P1)




Firefox 61
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed


(Reporter: osmose, Assigned: osmose)




(2 files)

In order to monitor browser error collection and measure its usefulness, I'd like to add six new scalars to the main ping:

    The count of all browser chrome JS errors that were collected locally.

    The count of browser chrome JS errors that were collected locally and had
    a usable stack trace.

    The count of all browser chrome JS errors that were reported to the
    remote collection service.

    The count of all browser chrome JS errors that we attempted to report to
    the remote collection service, but failed to.

    The sample rate at which collected errors were reported.

    The count of all browser chrome JS errors that were collected locally,
    keyed by the filename of the file in which the error occurred.
Data review for the new measures added.
Attachment #8958561 - Flags: review?(francois)
Comment on attachment 8958561 [details]
Data Collection Request

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Scalars.yml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default-on in Nightly only

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?


7) Is the data collection covered by the existing Firefox privacy notice?


8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are fine.
Attachment #8958561 - Flags: review?(francois) → review+
Priority: -- → P1
Comment on attachment 8958560 [details]
Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm.

:Gijs has approved the revision.
Chris H-C :chutten has approved the revision.
Attachment #8958560 - Flags: review+
Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Pushed by
Add Telemetry scalars for BrowserErrorReporter.jsm: update file after merge conflict CLOSED TREE
Backout by
Backed out changeset a760e111f2f1 for merge conflicts on browser_BrowserErrorReporter.js and failures after merging to autoland. a=backout
Backout by
Backed out changeset 803f2dfa6e12 for keep failling on BrowserErrorReporter.jsm after the merge conflict. CLOSED TREE
Michael, please do not land known conflicting patch into different integration branches at the same time. Conflicts wouldn't be resolved automatically, and that would just confuse sheriff and make the tree closed for longer.
This bug has been backed out in for merge conflicts with bug 1445009.

Since it seems the tree is a bit messed up after some unsuccessful backout, I directly reverted the files to the previous revision before both changes.
Flags: needinfo?(mkelly)
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
This is still backed out as per comment 15.
Flags: needinfo?(mkelly)
Resolution: FIXED → ---
Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
See Also: → 1484776
Depends on: 1513567
You need to log in before you can comment on or make changes to this bug.