In order to monitor browser error collection and measure its usefulness, I'd like to add six new scalars to the main ping: browser.errors.collected_count The count of all browser chrome JS errors that were collected locally. browser.errors.collected_with_stack_count The count of browser chrome JS errors that were collected locally and had a usable stack trace. browser.errors.reported_success_count The count of all browser chrome JS errors that were reported to the remote collection service. browser.errors.reported_failure_count The count of all browser chrome JS errors that we attempted to report to the remote collection service, but failed to. browser.errors.sample_rate The sample rate at which collected errors were reported. browser.errors.collected_count_by_filename The count of all browser chrome JS errors that were collected locally, keyed by the filename of the file in which the error occurred.
Data review for the new measures added.
Attachment #8958561 - Flags: review?(francois)
Comment on attachment 8958561 [details] Data Collection Request 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, in Scalars.yml. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Not permanent. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 1. 5) Is the data collection request for default-on or default-off? Default-on in Nightly only 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No 7) Is the data collection covered by the existing Firefox privacy notice? Yes 8) Does there need to be a check-in in the future to determine whether to renew the data? No, telemetry alerts are fine.
Attachment #8958561 - Flags: review?(francois) → review+
Comment on attachment 8958560 [details] Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. :Gijs has approved the revision. Chris H-C :chutten has approved the revision. https://phabricator.services.mozilla.com/D725
Attachment #8958560 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a760e111f2f157fbb18e66117f026ca298d4343e Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/803f2dfa6e12 Add Telemetry scalars for BrowserErrorReporter.jsm: update file after merge conflict CLOSED TREE
Backout by email@example.com: https://hg.mozilla.org/mozilla-central/rev/3d21d31141dc Backed out changeset a760e111f2f1 for merge conflicts on browser_BrowserErrorReporter.js and failures after merging to autoland. a=backout
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/7db445828978 Backed out changeset 803f2dfa6e12 for keep failling on BrowserErrorReporter.jsm after the merge conflict. CLOSED TREE
Michael, please do not land known conflicting patch into different integration branches at the same time. Conflicts wouldn't be resolved automatically, and that would just confuse sheriff and make the tree closed for longer.
This bug has been backed out in https://hg.mozilla.org/integration/autoland/rev/6e5043e04b88f201eeceb59165d213bc4b8b15e8 for merge conflicts with bug 1445009. Since it seems the tree is a bit messed up after some unsuccessful backout, I directly reverted the files to the previous revision before both changes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e32f5b50e77717939fbf4f7a96bda0eaa2561b Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f016656fb7439ff9eca989e1c119c8ebd12af2f Backed out changeset 68e32f5b50e7 (bug 1444554) for failing its own test. r=backout
Backed out again in https://hg.mozilla.org/integration/mozilla-inbound/rev/c2d1f86caeaf0a7dd9356bae8d5d6fe059d29c30 for failing its own tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=063a77201774afe587f91a1a96f799814544ef50&selectedJob=169357664 https://treeherder.mozilla.org/logviewer.html#?job_id=169357664&repo=mozilla-inbound
This is still backed out as per comment 15.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf74704e01c511fa066b2f5a7ea317e8ecd8863e Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Status: REOPENED → RESOLVED
Closed: Last year → Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.