Clean up warnings related to networkDetailsWidth prop

RESOLVED FIXED in Firefox 61

Status

P1
normal
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: glowka.tom, Assigned: glowka.tom)

Tracking

unspecified
Firefox 61

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Clean up after Bug 1434885, reported in Bug 1434885, comment 24

>I am seeing the following warning now:
> 
>Warning: Failed prop type: The prop `networkDetailsWidth` is marked as required in `RequestListContent`, but its value is >`null`.
>    in RequestListContent
>    in Unknown (created by Connect(Component))
>    in Connect(Component) (created by RequestList)
>    in div (created by RequestList)
>    in RequestList (created by MonitorPanel)
>    in div (created by SplitBox)
>    in div (created by SplitBox)
>    in SplitBox (created by MonitorPanel)
>    in div (created by MonitorPanel)
>    in MonitorPanel
>    in VisibilityHandler
>    in Unknown (created by Connect(Component))
>    in Connect(Component) (created by App)
>    in div (created by DropHarHandler)
>    in DropHarHandler (created by App)
>    in div (created by App)
>    in App
>    in VisibilityHandler
>    in Unknown (created by Connect(Component))
>    in Connect(Component)
>    in Provider

I will take care of it, please assign me.
(Assignee)

Updated

a year ago
Depends on: 1434885
(Assignee)

Updated

a year ago
Attachment #8957815 - Flags: review?(odvarko)
Comment on attachment 8957815 [details]
Bug 1444594 - set correct prop-types in RequstListContent to clean up some warnings

https://reviewboard.mozilla.org/r/226800/#review235004

Thanks for the patch!

R+

Honza
Attachment #8957815 - Flags: review?(odvarko) → review+
Assignee: nobody → glowka.tom
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 4

a year ago
It's kind of trivial, but let me make sure: I can safely set checkin-needed, right? Or should I rather get green from try before it?
Flags: needinfo?(odvarko)
(In reply to Tom Glowka from comment #4)
> It's kind of trivial, but let me make sure: I can safely set checkin-needed,
> right? Or should I rather get green from try before it?
Yeah, this one is fairly simple, so you might probably
skip the Try, also depends how brave you are ;-)

Honza
Flags: needinfo?(odvarko)
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d918859fa3fb
set correct prop-types in RequstListContent to clean up some warnings r=Honza
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d918859fa3fb
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.