1444594 - Clean up warnings related to networkDetailsWidth prop

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Comment 1

[Tom Glowka]

Clean up after Bug 1434885, reported in Bug 1434885, comment 24

>I am seeing the following warning now:
> 
>Warning: Failed prop type: The prop `networkDetailsWidth` is marked as required in `RequestListContent`, but its value is >`null`.
>    in RequestListContent
>    in Unknown (created by Connect(Component))
>    in Connect(Component) (created by RequestList)
>    in div (created by RequestList)
>    in RequestList (created by MonitorPanel)
>    in div (created by SplitBox)
>    in div (created by SplitBox)
>    in SplitBox (created by MonitorPanel)
>    in div (created by MonitorPanel)
>    in MonitorPanel
>    in VisibilityHandler
>    in Unknown (created by Connect(Component))
>    in Connect(Component) (created by App)
>    in div (created by DropHarHandler)
>    in DropHarHandler (created by App)
>    in div (created by App)
>    in App
>    in VisibilityHandler
>    in Unknown (created by Connect(Component))
>    in Connect(Component)
>    in Provider

I will take care of it, please assign me.

Comment 2

[Tom Glowka]

Attachment: Bug 1444594 - set correct prop-types in RequstListContent to clean up some warnings

Review commit: https://reviewboard.mozilla.org/r/226800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226800/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8957815 [details]
Bug 1444594 - set correct prop-types in RequstListContent to clean up some warnings

https://reviewboard.mozilla.org/r/226800/#review235004

Thanks for the patch!

R+

Honza

Comment 4

[Tom Glowka]

It's kind of trivial, but let me make sure: I can safely set checkin-needed, right? Or should I rather get green from try before it?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tom Glowka from comment #4)
> It's kind of trivial, but let me make sure: I can safely set checkin-needed,
> right? Or should I rather get green from try before it?
Yeah, this one is fairly simple, so you might probably
skip the Try, also depends how brave you are ;-)

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d918859fa3fb
set correct prop-types in RequstListContent to clean up some warnings r=Honza

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/d918859fa3fb