Closed Bug 1444596 Opened 2 years ago Closed 2 years ago

Remove unnecessary search overlay

Categories

(Thunderbird :: Search, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

From IRC:

18:55 Paenglab searchOverlay.xul overlays messenger.xul. searchOverlay.xul loads searchOverlay.js which has only one line: ChromeUtils.import("resource:///modules/SearchIntegration.js");
18:55 Paenglab Wouldn't it be simpler to add this line to a js file which is already loaded through messenger.xul?
18:59 Paenglab Ah, I see now, msgMail3PaneWindow.js already has this line. Can we remove the searchOverlay.* files?
This patch removes the overlay.
Try on Mac and Windows where the search should be tested: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=59c52c4bf10a575c0f2ae0ab230b476f339be1a0
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8957794 - Flags: review?(jorgk)
Blocks: 1444468
Comment on attachment 8957794 [details] [diff] [review]
searchOverlay.patch

Looks reasonable and nothing broke ;-)
Attachment #8957794 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7fdce669bb09
Remove unnecessary search overlay. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.