Middle/Ctrl/Cmd-clicking bookmark folders in sidebar doesn't open all in tabs anymore

RESOLVED FIXED in Firefox 60

Status

()

defect
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philipp, Assigned: standard8)

Tracking

({regression})

60 Branch
Firefox 61
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox58 unaffected, firefox59 unaffected, firefox60+ fixed, firefox61 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

a year ago
we have received a report about this regression in the sumo forum at https://support.mozilla.org/questions/1208595

this behaviour is reproducible and was introduced by bug 517719.

Updated

a year ago
Duplicate of this bug: 1444741
Mark, could you please look into this?
Flags: needinfo?(standard8)
Assignee

Comment 3

a year ago
From the console:

TypeError: tbo.view.nodeForTreeIndex is not a function[Learn More]  sidebarUtils.js:46:47
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Priority: -- → P1
Whiteboard: [fxsearch]
asking tracking since this is a new regression affecting a common functionality

Comment 7

a year ago
mozreview-review
Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

https://reviewboard.mozilla.org/r/227018/#review232768

::: browser/components/places/tests/browser/browser_sidebar_open_bookmarks.js:9
(Diff revision 1)
> +"use strict";
> +
> +let sidebar = document.getElementById("sidebar");
> +
> +const TEST_URI = "http://example.com/";
> +var bms;

nit: let above, var here. please just stick to one in the global scope. Prefixing with g is encouraged.
Attachment #8958067 - Flags: review?(mak77) → review+
Comment hidden (mozreview-request)

Comment 9

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b3a36becdd8
Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking. r=mak

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6b3a36becdd8
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
please request uplift to beta when you get a chance.
Flags: needinfo?(standard8)
Assignee

Comment 12

a year ago
Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 517719
[User impact if declined]: Users won't be able to middle/ctrl/cmd click bookmark folders to open them.
[Is this code covered by automated tests?]: This now has tests.
[Has the fix been verified in Nightly?]: Landed in nightly, I've just tested it.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple one line fix, tests included
[String changes made/needed]: None
Flags: needinfo?(standard8)
Attachment #8958067 - Flags: approval-mozilla-beta?
Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

regression fix for bookmark folders, beta60+
Attachment #8958067 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Settings qe-verify- based on comment 12.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.