1444599 - Middle/Ctrl/Cmd-clicking bookmark folders in sidebar doesn't open all in tabs anymore

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[[:philipp]]

we have received a report about this regression in the sumo forum at https://support.mozilla.org/questions/1208595

this behaviour is reproducible and was introduced by bug 517719.

Comment 2

[Marco Bonardo [:mak]]

Mark, could you please look into this?

Comment 3

[Mark Banner (:standard8)]

From the console:

TypeError: tbo.view.nodeForTreeIndex is not a function[Learn More]  sidebarUtils.js:46:47

Comment 4

[Marco Bonardo [:mak]]

asking tracking since this is a new regression affecting a common functionality

Comment 5

[Julien Cristau [:jcristau]]

tracking per comment 4

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

Review commit: https://reviewboard.mozilla.org/r/227018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227018/

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

https://reviewboard.mozilla.org/r/227018/#review232768

::: browser/components/places/tests/browser/browser_sidebar_open_bookmarks.js:9
(Diff revision 1)
> +"use strict";
> +
> +let sidebar = document.getElementById("sidebar");
> +
> +const TEST_URI = "http://example.com/";
> +var bms;

nit: let above, var here. please just stick to one in the global scope. Prefixing with g is encouraged.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227018/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b3a36becdd8
Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking. r=mak

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/6b3a36becdd8

Comment 11

[Julien Cristau [:jcristau]]

please request uplift to beta when you get a chance.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 517719
[User impact if declined]: Users won't be able to middle/ctrl/cmd click bookmark folders to open them.
[Is this code covered by automated tests?]: This now has tests.
[Has the fix been verified in Nightly?]: Landed in nightly, I've just tested it.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple one line fix, tests included
[String changes made/needed]: None

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8958067 [details]
Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking.

regression fix for bookmark folders, beta60+

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/944ddfae2be0

Comment 15

[Bogdan Maris, Desktop QA]

Settings qe-verify- based on comment 12.