Closed Bug 1444614 Opened 2 years ago Closed 2 years ago

urlbar binding constructor initializes gBrowser and gBrowser.tabContainer early

Categories

(Firefox :: Address Bar, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8957804 [details]
Bug 1444614 - Avoid initializing gBrowser and gBrowser.tabContainer early in the urlbar binding constructor.

https://reviewboard.mozilla.org/r/226792/#review232582

Tentative r=me ... I'm a little worried that we're building what seems like a fragile-seeming house of cards here in terms of initialization orders that aren't explicitly defined but that we do shuffle things around for. But I don't have better ideas, and I suppose there's no a priori reason it was any less fragile before - it just happened to work...
Attachment #8957804 - Flags: review?(gijskruitbosch+bugs) → review+
To be clear, the urlbar binding touching gBrowser shouldn't break things. It's just that we shouldn't unintentionally initialize gBrowser early in the window opening process. Who knows what's causing the urlbar binding to be constructed before gBrowser was ready, but in any case it seems better to not let this affect gBrowser.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6379a27eb701
Avoid initializing gBrowser and gBrowser.tabContainer early in the urlbar binding constructor. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/6379a27eb701
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.