1444614 - urlbar binding constructor initializes gBrowser and gBrowser.tabContainer early

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1444614 - Avoid initializing gBrowser and gBrowser.tabContainer early in the urlbar binding constructor.

Review commit: https://reviewboard.mozilla.org/r/226792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226792/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8957804 [details]
Bug 1444614 - Avoid initializing gBrowser and gBrowser.tabContainer early in the urlbar binding constructor.

https://reviewboard.mozilla.org/r/226792/#review232582

Tentative r=me ... I'm a little worried that we're building what seems like a fragile-seeming house of cards here in terms of initialization orders that aren't explicitly defined but that we do shuffle things around for. But I don't have better ideas, and I suppose there's no a priori reason it was any less fragile before - it just happened to work...

Comment 3

[Dão Gottwald [:dao]]

To be clear, the urlbar binding touching gBrowser shouldn't break things. It's just that we shouldn't unintentionally initialize gBrowser early in the window opening process. Who knows what's causing the urlbar binding to be constructed before gBrowser was ready, but in any case it seems better to not let this affect gBrowser.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6379a27eb701
Avoid initializing gBrowser and gBrowser.tabContainer early in the urlbar binding constructor. r=Gijs

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6379a27eb701