Closed
Bug 1444625
Opened 6 years ago
Closed 6 years ago
Set gBrowser properties directly on the object rather than sequentially in init()
Categories
(Firefox :: Tabbed Browser, enhancement)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(2 files)
|
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
|
Details |
|
11.43 KB,
patch
|
Details | Diff | Splinter Review |
This is closer to the old tabbrowser binding implementation and should prevent things like bug 1444510.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d7300e966e0bec87b39fe885680380f6d607e46
|
|
Assignee | |
Comment 3•6 years ago
|
||
Probably a bit easier to review than reviewboard's presentation...
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8957822 [details] Bug 1444625 - Set gBrowser properties directly on the object rather than sequentially in init(). https://reviewboard.mozilla.org/r/226796/#review232600 Thanks for the normal diff. Yes, that was a lot easier to review. I basically haven't looked at this - it'd best be the same! ;-)
Attachment #8957822 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/511cd50ae276 Set gBrowser properties directly on the object rather than sequentially in init(). r=Gijs
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/511cd50ae276
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•