Closed Bug 1444631 Opened 2 years ago Closed 6 days ago

Intermittent browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/

Categories

(Firefox :: Menus, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox-esr60 --- disabled
firefox63 --- disabled
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(2 files, 1 obsolete file)

Duplicate of this bug: 1444697
There have been 38 failures in the last 7 days:

osx-10-10 / opt & debug: 29
linux64 / opt & debug: 5
linux32 / opt: 4

Recent log file and snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?job_id=189977891&repo=autoland&lineNumber=13744

00:16:14     INFO - TEST-PASS | browser/base/content/test/general/browser_utilityOverlay.js | example.com loaded - 
00:16:14     INFO - Buffered messages logged at 00:16:14
00:16:14     INFO - Running test_openUILink
00:16:14     INFO - Buffered messages finished
00:16:14     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/
00:16:14     INFO - Stack trace:
00:16:14     INFO - chrome://mochikit/content/browser-test.js:test_is:1306
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openUILink/<:105
00:16:14     INFO - promise callback*chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openUILink:104
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openNewTabWith/<:98
00:16:14     INFO - promise callback*chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openNewTabWith:95
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_getBoolPref:89
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_getTopWin:81
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_eventMatchesKey:76
00:16:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
00:16:14     INFO - chrome://mochikit/content/browser-test.js:run:1335
00:16:14     INFO - GECKO(828) | MEMORY STAT | vsize 5722MB | residentFast 945MB | heapAllocated 273MB
00:16:14     INFO - TEST-OK | browser/base/content/test/general/browser_utilityOverlay.js | took 1454ms
Flags: needinfo?(dolske)
Whiteboard: [stockwell needswork]
Update:
There have been 78 failures in the last 7 days and 138 failures in the last 21 days.

- osx-10-10 / opt & debug: 61
- linux64 / all builds except opt: 12
- linux32 / opt: 4
- macosx64-nightly / opt: 1

Recent log file and snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?job_id=193463216&repo=autoland&lineNumber=11972

07:46:37     INFO - TEST-PASS | browser/base/content/test/general/browser_utilityOverlay.js | getBoolPref - 
07:46:37     INFO - TEST-PASS | browser/base/content/test/general/browser_utilityOverlay.js | getBoolPref fallback - 
07:46:37     INFO - TEST-PASS | browser/base/content/test/general/browser_utilityOverlay.js | getBoolPref fallback #2 - 
07:46:37     INFO - Running test_openNewTabWith
07:46:37     INFO - Buffered messages logged at 07:46:36
07:46:37     INFO - TEST-PASS | browser/base/content/test/general/browser_utilityOverlay.js | example.com loaded - 
07:46:37     INFO - Running test_openUILink
07:46:37     INFO - Buffered messages finished
07:46:37     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/
07:46:37     INFO - Stack trace:
07:46:37     INFO - chrome://mochikit/content/browser-test.js:test_is:1308
07:46:37     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openUILink/<:105
07:46:37     INFO - promise callback*chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openUILink:104
07:46:37     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:runNextTest:22
07:46:37     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_utilityOverlay.js:test_openNewTabWith/<:98
Attached patch Diasbled on linux and mac (obsolete) — Splinter Review
Created a patch if needed to disable "browser_utilityOverlay.js" on linux and mac
Assignee: nobody → aiakab
Attachment #8999418 - Flags: review?(jmaher)
Comment on attachment 8999418 [details] [diff] [review]
Diasbled on linux and mac

Review of attachment 8999418 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8999418 - Flags: review?(jmaher) → review+
Assignee: aiakab → nobody
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Summary: Intermittent browser/base/content/test/general/browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/ → Intermittent browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/
Could not land this.
Got applying Bug1444631
patching file browser/base/content/test/general/browser.ini
Hunk #1 FAILED at 472
1 out of 1 hunks FAILED
Flags: needinfo?(aiakab)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fbfb6dcd887
Disabled browser_utilityOverlay.js on linux and mac. r=jmaher
Flags: needinfo?(aiakab)
Backed out for build bustages

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1fbfb6dcd8879a654a1e60d799a9b8460a52a117

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193827128&repo=mozilla-inbound&lineNumber=1557

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/31bcd77ca52ec19bb25233131eb25b5a32bf9013

[task 2018-08-14T10:02:49.896Z] 10:02:49     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2018-08-14T10:02:49.896Z] 10:02:49     INFO -  ==============================
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -  ==============================
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -      /builds/worker/workspace/build/src/browser/base/moz.build
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -      Error processing test manifest file /builds/worker/workspace/build/src/browser/base/content/test/general/browser.ini: Traceback (most recent call last):
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -        File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 1481, in _process_test_manifest
[task 2018-08-14T10:02:49.897Z] 10:02:49     INFO -          path, ', '.join(missing)), context)
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      SandboxValidationError:
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      ==============================
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      FATAL ERROR PROCESSING MOZBUILD FILE
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      ==============================
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      The error occurred while processing the following file or one of the files it includes:
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -          /builds/worker/workspace/build/src/browser/base/moz.build
[task 2018-08-14T10:02:49.898Z] 10:02:49     INFO -      The error occurred when validating the result of the execution. The reported error is:
[task 2018-08-14T10:02:49.899Z] 10:02:49     INFO -          Test manifest (/builds/worker/workspace/build/src/browser/base/content/test/general/browser.ini) lists test that does not exist: browser_utilityOverlay.js
[task 2018-08-14T10:02:50.383Z] 10:02:50     INFO -  *** Fix above errors and then restart with\
[task 2018-08-14T10:02:50.383Z] 10:02:50     INFO -                 "/usr/bin/make -f client.mk build"
[task 2018-08-14T10:02:50.383Z] 10:02:50     INFO -  client.mk:123: recipe for target 'configure' failed
[task 2018-08-14T10:02:50.383Z] 10:02:50     INFO -  make: *** [configure] Error 1
[task 2018-08-14T10:02:50.448Z] 10:02:50    ERROR - Return code: 2
[task 2018-08-14T10:02:50.449Z] 10:02:50  WARNING - setting return code to 2
the test case was moved yesterday to a different file, effectively this was a case of bitrot.  we need to redo this patch to use the new file.
Whiteboard: [stockwell disabled] → [stockwell disable-recommended]
In the new file.
Attachment #8999418 - Attachment is obsolete: true
Attachment #8999889 - Flags: review?(jmaher)
Comment on attachment 8999889 [details] [diff] [review]
Disable on linux and mac

Review of attachment 8999889 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for updating this!
Attachment #8999889 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1a2c51657b4
Disable browser_utilityOverlay.js on linux and mac for frequent failures. r=jmaher
Keywords: checkin-needed
Declaring new-year needinfo bankruptcy.
Flags: needinfo?(dolske)
There are 5 total failures in the last 7 days.

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219783598&repo=mozilla-release&lineNumber=2493

14:47:46     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_utilityOverlay.js | got top window - 
14:47:46     INFO - Running test_openNewTabWith
14:47:46     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 867}]
14:47:46     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_utilityOverlay.js | example.com loaded - 
14:47:46     INFO - Running test_openUILink
14:47:46     INFO - Buffered messages finished
14:47:46     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_utilityOverlay.js | example.org loaded - Got about:blank, expected http://example.org/
14:47:46     INFO - Stack trace:
14:47:46     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
14:47:46     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/browser_utilityOverlay.js:test_openUILink/<:96
14:47:46     INFO - GECKO(5664) | MEMORY STAT | vsize 780MB | vsizeMaxContiguous 717MB | residentFast 285MB | heapAllocated 118MB
14:47:46     INFO - TEST-OK | browser/base/content/test/contextMenu/browser_utilityOverlay.js | took 578ms
Component: General → Menus

There seems to have been a spike here between the 6th and 10th of October with 24 total failures, however failure rate is going down apparently. We'll keep an eye on this.

Jared can you assign someone to take a look?

Flags: needinfo?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Whiteboard: [stockwell disabled] → [stockwell unknown]
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c75b52fa7f43
fix browser_utilityOverlay.js to not trip over about:blank loads, r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 6 days ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell unknown] → [stockwell fixed]

Comment on attachment 9107201 [details]
Bug 1444631 - fix browser_utilityOverlay.js to not trip over about:blank loads, r?nhnt11

Beta/Release Uplift Approval Request

  • User impact if declined: test-only
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test-only change
  • String changes made/needed: No
Attachment #9107201 - Flags: approval-mozilla-beta?

Comment on attachment 9107201 [details]
Bug 1444631 - fix browser_utilityOverlay.js to not trip over about:blank loads, r?nhnt11

Test-only change, uplift approved for 71 beta 10, thanks.

Attachment #9107201 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.