1444666 - get rid of nsSVGUtils version of GetStrokeDashData and replace by SVGContentUtils::GetStrokeOptions

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8957849 [details] [diff] [review]
patch

Review of attachment 8957849 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find!

::: gfx/thebes/gfxContext.h
@@ +286,4 @@
>       * Paints the current source surface/pattern everywhere in the current
>       * clip region.
>       */
> +    void Paint(mozilla::gfx::Float alpha = 1.0);

Nit: Could you put a typedef for Float at the beginning of the class so we don't need to prefix throughout this header?

::: layout/svg/SVGContextPaint.h
@@ +96,4 @@
>    void InitStrokeGeometry(gfxContext *aContext,
>                            float devUnitsPerSVGUnit);
>  
> +  const FallibleTArray<mozilla::gfx::Float>& GetStrokeDashArray() const {

Nit: typedef.

::: layout/svg/nsSVGUtils.cpp
@@ +1699,2 @@
>  
> +  if (strokeOptions.mLineWidth <= 0)

Curly braces to match style guidelines.

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc2f6c7222cea1fbbf581fb7657c0a4c066bed79

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/54ed9f585985
get rid of nsSVGUtils version of GetStrokeDashData and replace by SVGContentUtils::GetStrokeOptions r=jwatt

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/54ed9f585985