1444754 - Show a warning for a potential startup performance issue if the user use all or all-future options in unifinder

Status: NEW

(Calendar :: Calendar Frontend, enhancement)

Description

[[:MakeMyDay]]

Since we have bug reports now and then about (startup) performance when people have enabled unifinder and are using all or all_future filter, it might be a good idea to show a notification in that case to inform about potential perfomance issues.

Comment 1

[[:MakeMyDay]]

Attachment: NotifyPerformanceSensitiveUnifinderScope-V1.diff

One more l10n patch.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8957952 [details] [diff] [review]
NotifyPerformanceSensitiveUnifinderScope-V1.diff

Review of attachment 8957952 [details] [diff] [review]:
-----------------------------------------------------------------

So IIUC this notification would persist and show each time. I think that would be too intrusive. 

Can we detect this in a more advanced way and only show the warning if there are actually performance issues? e.g. the time it takes to display all events in the list takes more then N seconds?

Have you received any recent such reports? I haven't heard anything in a while on unifinder performance.

Comment 3

[[:MakeMyDay]]

There are startup performance complaints every now and then. People don't have in mind that having the unifinder enabled with that settings might conztribute to that experience. But I don't have a recent bug number at hand.

all or all_future shouldn't imho be a setting for day to day operation, so I am not too concerned about the persistence. But I can make it more smart in a follow patch in this bug, if we get the first patch landed before string freeze.

Comment 4

[Stefan Sitter [:ssitter]]

Keep in mind that there are more settings that might impact performance. For example task filter 'all' in today pane or task filter 'all' in task tab. I'd reject the patch unless there is an option to disable it. Or make it smarter and display only if there actually is a large number of events or a large number of calendars.

Comment 5

[[:MakeMyDay]]

Thanks. I haven't checked codewise, but are both task filters independent to each other or is that just a display issue that the filter in the today pane doesn't have the checkmark set on the filter selected in task view?

Apart from the current patch, would it in general make more sense for you to notify the user about performance sensitive setting or better restrict the critical filter options to a less problematic scope at all instead?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

One possible option would be to have a set of filters that auto-reset after a specific interval of time. I spoke with MMD yesterday and I am not particularly thrilled about having a non-dismissable notification.

Another thing we could do is have it default to a faster filter on startup, if a slow filter was persisted. This would still be annoying to those who really want the all events filter, but we could fix that with an extension that has a specific performance disclaimer.