Closed Bug 1444823 Opened 2 years ago Closed 2 years ago

Execute messageManager.sendAsyncMessage after runTest in bulklog and objectexpand

Categories

(DevTools :: General, enhancement, P3)

59 Branch
enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jdescottes, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

From comment on Bug 1441703:

> ::: testing/talos/talos/tests/devtools/addon/content/tests/webconsole/bulklog.js:51
> (Diff revision 4)
> > +  ) + ")()", true);
> > +
> > +  // Kick off the logging
> > +  messageManager.sendAsyncMessage("do-logs");
> > +
> > +  let test = runTest("console.bulklog");
> 
> I didn't realized but `messageManager.sendAsyncMessage("do-logs");` should 
> probably be execute after `runTest` call.
>
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8958745 [details]
Bug 1444823 - Execute messageManager.sendAsyncMessage after runTest; .

https://reviewboard.mozilla.org/r/227668/#review233410

Looks good to me thanks!
Attachment #8958745 - Flags: review?(jdescottes) → review+
TRY is green with a g2 job. Let's land this
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a7a26b914ac
Execute messageManager.sendAsyncMessage after runTest; r=jdescottes.
https://hg.mozilla.org/mozilla-central/rev/3a7a26b914ac
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.