1444858 - TRR: respect network.dns.disableIPv6

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

network.dns.disableIPv6 set to false means no IPv6 should be asked for with DNS, including TRR!

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1444858 - TRR: respect network.dns.disableIPv6

Review commit: https://reviewboard.mozilla.org/r/227030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227030/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8958079 [details]
bug 1444858 - TRR: respect network.dns.disableIPv6

https://reviewboard.mozilla.org/r/227030/#review232760

::: netwerk/dns/TRRService.cpp:206
(Diff revision 1)
>      bool tmp;
>      if (NS_SUCCEEDED(Preferences::GetBool(TRR_PREF("early-AAAA"), &tmp))) {
>        mEarlyAAAA = tmp;
>      }
>    }
> +  if (!name || !strcmp(name, "network.dns.disableIPv6")) {

Do we want to add an Observer as well?

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8958079 [details]
bug 1444858 - TRR: respect network.dns.disableIPv6

https://reviewboard.mozilla.org/r/227030/#review232760

> Do we want to add an Observer as well?

Oops, yes we do. Good catch. Will fix.

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8958079 [details]
bug 1444858 - TRR: respect network.dns.disableIPv6

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227030/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ce40b123f12
TRR: respect network.dns.disableIPv6 r=valentin

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8ce40b123f12