1444887 - TRR: restarted DNS service makes TRR wait for captive portal in vain

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

When the DNS service restarts (which it does on network change events and even DNS pref updates), it restarts the TRR service as well.

When the TRR service gets restarted it starts up without knowing the captive portal state and ends up sitting waiting for that event to arrive before it gets used. An event that won't be sent again.

TRR thus needs to check the state on startup in case it has already been confirmed "green".

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1444887 TRR: get captive portal state in init

To prevent it from sitting waiting for an event that was sent before the
TRRService started.

Review commit: https://reviewboard.mozilla.org/r/227026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227026/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8958076 [details]
bug 1444887 TRR: get captive portal state in init

https://reviewboard.mozilla.org/r/227026/#review232764

::: netwerk/dns/TRRService.cpp:78
(Diff revision 1)
>    }
> +  nsCOMPtr<nsICaptivePortalService> captivePortalService =
> +    do_GetService(NS_CAPTIVEPORTAL_CID);
> +  if (captivePortalService) {
> +    int32_t captiveState;
> +    captivePortalService->GetState(&captiveState);

nit: wrap in MOZ_ALWAYS_SUCCEEDS

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8958076 [details]
bug 1444887 TRR: get captive portal state in init

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227026/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/491cb5f5bd9e
TRR: get captive portal state in init r=valentin

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/491cb5f5bd9e