Closed Bug 1444917 Opened 2 years ago Closed 11 months ago

Intermittent test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") | (TIMEOUT) [300.0 s]

Categories

(Core :: JavaScript: Internationalization API, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: anba, NeedInfo)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=167404372&repo=mozilla-central

https://queue.taskcluster.net/v1/task/c_oz9eJAQUCopEWBHQLRjg/runs/0/artifacts/public/logs/live_backing.log

[task 2018-03-12T13:44:42.052Z] TEST-UNEXPECTED-FAIL | test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") | (TIMEOUT) [300.0 s]
[task 2018-03-12T13:44:42.053Z] {"action": "test_start", "pid": 67892, "source": "jstests", "test": "test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js", "thread": "main", "time": 1520861982.012249}
[task 2018-03-12T13:44:42.054Z] {"action": "test_end", "extra": {"jitflags": [], "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "pid": 67892, "source": "jstests", "status": "FAIL", "test": "test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js", "thread": "main", "time": 1520862282.052897}
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
In the last 7 days there are 31 failures associated with this bug.
They occur on linux64 debug.
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=203976319&repo=mozilla-central&lineNumber=83527

Waldo: Hi, Can you please have a look into this? Thanks!
Flags: needinfo?(jwalden+bmo)
Whiteboard: [stockwell needswork]
When locally running this test in an opt-debug build, about 75% or so of the time was spent parsing and validating language tags in assert statements. Maybe it helps to (re)move some of these assert calls?
This bug has failed 42 times in the last 7 days. This occurs on Linux64 on debug build type.

Recent log:
https://treeherder.mozilla.org/logviewer.html#?job_id=208027548&repo=autoland&lineNumber=106618

Waldo: Can you please take a look at this bug?
Attached patch bug1444917.patchSplinter Review
- The patch moves the language tag checking from |startOfUnicodeExtensions| and |endOfUnicodeExtensions| to their callers, so we don't check it first in |startOfUnicodeExtensions| and then shortly after again in |endOfUnicodeExtensions|.
- Additionally the language tag validation is now performed in a macro, so we don't need to parse the tag an additional time when calling |CanonicalizeLanguageTag|.
  - I'm using a macro instead of a function call to ensure debug assertion messages point to the correct source location in the self-hosted code.

The reduces the time needed to complete "test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js" in a debug-opt build by 50% for me, which should be enough to fix the intermittent issue.
Assignee: nobody → andrebargull
Status: REOPENED → ASSIGNED
Attachment #9020740 - Flags: review?(jwalden+bmo)
There are 31 total failures in the last 30 days, all on linux64 debug. 

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209879085&repo=autoland&lineNumber=103827

[task 2018-11-05T18:46:32.894Z] TEST-PASS | test262/built-ins/Array/prototype/forEach/15.4.4.18-2-13.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.1 s]
[task 2018-11-05T18:46:32.895Z] {"action": "test_start", "jitflags": [], "pid": 28395, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "test262/built-ins/Array/prototype/forEach/15.4.4.18-2-13.js", "thread": "main", "time": 1541443592.756052}
[task 2018-11-05T18:46:32.895Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 28395, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 28395, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "PASS", "test": "test262/built-ins/Array/prototype/forEach/15.4.4.18-2-13.js", "thread": "main", "time": 1541443592.895035}
[task 2018-11-05T18:46:32.898Z] TEST-UNEXPECTED-FAIL | test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") | (TIMEOUT) [300.1 s]
[task 2018-11-05T18:46:32.899Z] {"action": "test_start", "jitflags": [], "pid": 98979, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js", "thread": "main", "time": 1541443292.83554}
[task 2018-11-05T18:46:32.900Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 98979, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 98979, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "FAIL", "test": "test262/intl402/supportedLocalesOf-unicode-extensions-ignored.js", "thread": "main", "time": 1541443592.899419}
[task 2018-11-05T18:46:32.903Z] TEST-PASS | test262/built-ins/Array/prototype/forEach/15.4.4.18-5-18.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.1 s]
[task 2018-11-05T18:46:32.904Z] {"action": "test_start", "jitflags": [], "pid": 28408, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "test262/built-ins/Array/prototype/forEach/15.4.4.18-5-18.js", "thread": "main", "time": 1541443592.764575}
[task 2018-11-05T18:46:32.904Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 28408, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 28408, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "PASS", "test": "test262/built-ins/Array/prototype/forEach/15.4.4.18-5-18.js", "thread": "main", "time": 1541443592.903446}

A patch has been made and is currently waiting for review.
Attachment #9020740 - Flags: review?(jwalden+bmo) → review+
Keywords: checkin-needed
Whiteboard: [stockwell needswork] → [stockwell needswork]
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f77121fb76fc
Combine tests for valid and canonical language tags in assertions. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f77121fb76fc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.