1444931 - revision tooltip shows escaped characters in commit message

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Example: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e29b542016965349d12ed6c2c52b2f08e513d9cf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Move your mouse over the fourth revision from the top: Bug 1444283: Label the "Autofill addresses" and "autofill credit cards" check boxes for accessibility. r=MattN
Actual result: Same message like always shown label but " replaced with "
Expected result: Same content as label.

Caused by escaping the string despite setting it from JavaScript (React).

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3334

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8958126 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3334

Looks good!  If you would please fix the commit message as Ed mentioned, then we can merge this.  I take it you can merge it yourself?  If not, please n-i me to let me know when it's ready.

Thanks!

Comment 3

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #2)
> I take it you can merge it yourself?  If not,
> please n-i me to let me know when it's ready.

The list of people with push access is here:
https://github.com/orgs/mozilla/teams/treeherder/members

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/76e8741f2f7515e3059849e1d65b5cdb960eff89
Bug 1444931 - Fix escaped characters in commit message tooltips (#3334)

Comment 5

[Ed Morley [:emorley]]

Actually since this has r+ I've merged now and fixed using github's "squash and merge" :-)

Comment 6

[Ed Morley [:emorley]]

Many thanks for the PR!