Closed Bug 1444985 Opened 6 years ago Closed 6 years ago

Webrender: text-shadows mostly don't render

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected

People

(Reporter: Gankra, Assigned: Gankra)

References

Details

(Keywords: correctness) 

data:text/html,<body style="text-shadow: 2px 2px 3px black, -2px -2px 3px red;">HELLO!</body>

only draws the black shadow for no clear reason

A bunch of stuff is also missing from https://gankro.github.io/blah/webtests/text.html
confirmed on macos and windows; probably linux too
mozregression says this broke about a month ago: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9bc3906d3dc9535d26c4d172df8457d853b86d2b&tochange=f53e340b051cec79c3dab594fe87e8e805ba2fab

which includes a wr update including this range: 08e49649f1fc9cacff4e10ebc390babcea752236..342bc314db94aa439b2001249c5f24ccfcbccc22

suspicious: this webrender range includes lsalzman's changes to fast shadows, although I wouldn't immediately expect that to do anything to slow shadows...?

also weird: mrobinson+mine's slow-shadow clipping changes that landed a couple days ago indicates slow shadows seem to be working in wrench perfectly fine...?
Update: they really aren't working fine in wrench either.
Fixed upstream, just needs a webrender update.
Depends on: 1444946
Which upstream PR fixed this?
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59: --- → unaffected
status-firefox60: --- → unaffected
status-firefox61: affected → unaffected
status-firefox-esr52: --- → unaffected
Keywords: correctness
Resolution: --- → FIXED
See Also: → https://github.com/servo/webrender/pull/2515
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.