1444987 - Targeted unread count badge border radius does not apply

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: badge-edges.png

The badge on the chat button that shows the count of unread mentions/targeted messages does not get its borders rounded properly when a value is set.

A possible fix is to wrap the label in a box and style the box instead.

Comment 1

[Patrick Cloke [:clokep]]

I think I'm seeing the same behavior on current beta, but I'm not 100% sure how it is SUPPOSED to look.

Maybe Richard has an idea if there is anything actionable here?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1444987-badge-radius.patch

It seems on the label itself border-radius works no more. Wrapping the label inside a box and apply the styles to the box fixes this.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: comparison.png

Comparison of with and without the patch.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 9036516 [details] [diff] [review]
1444987-badge-radius.patch

Review of attachment 9036516 [details] [diff] [review]:
-----------------------------------------------------------------

So I wasn't really sure whether to approve this or not -- I think we could do a much better job with this icon. I'm giving it an r+ because it fixes the actual issue and I think we should uplift this to beta sooner rather than later.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 9036516 [details] [diff] [review]
1444987-badge-radius.patch

[Approval Request Comment]
Regression caused by (bug #): See attachment 9037416 [details]
User impact if declined: Broken styling on icon
Testing completed (on c-c, etc.): None
Risk to taking this patch (and alternatives if risky): Small risk, if anything the styling will just be broken in a different way

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/151bb059674b
Make the border-radius on the badges working again. r=clokep

Comment 7

[Patrick Cloke [:clokep]]

We should probably wait on uplifting this since we suspect it is causing bug 1521481.

Comment 8

[Jorg K (CEST = GMT+2)]

TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/48b416ee9271b60a781429b96e671fe4e4ea93e0