1445035 - Investigate baselineCompile() correctness by comparing it to CanEnterBaselineJIT

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jason Orendorff [:jorendorff]]

CanEnterBaselineJIT() checks some things that look like hard requirements:

    if (script->length() > BaselineScript::MAX_JSSCRIPT_LENGTH)
        return Method_CantCompile;

    if (script->nslots() > BaselineScript::MAX_JSSCRIPT_SLOTS)
        return Method_CantCompile;

and some things that look like heuristics:

    // Check script warm-up counter.
    if (script->incWarmUpCounter() <= JitOptions.baselineWarmUpThreshold)
        return Method_Skipped;

To try to get ahead of further fallout from the baselineCompile() testing function, I would like to know which is which and make sure the testing function is enforcing all of the hard requirements.

I'll write a patch with my guesses and let nbp correct me. :)