1445073 - Pass XPTInterfaceDirectoryEntry into xptiInterfaceEntry::Create()

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

I'm trying to resist doing more cleanups in this code, but I keep stumbling over this little bit of cruftiness. XPTInterfaceInfoManager::VerifyAndAddEntryIfNew() takes a directory entry, pulls out the three pieces of it, then passes them to xptiInterfaceEntry::Create(). Passing in the directory entry is simpler. Also, it sets flags on the entry after Create() returns it, but the ctor could just set the flags itself. Finally, there's a comment that refers to a function SetHeader() which does not seem to exist any more.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1445073 - Pass XPTInterfaceDirectoryEntry into xptiInterfaceEntry::Create().

Also, I set some flags in the ctor instead of later and I also removed
a comment which refers to SetHeader(), which does not exist any more.

Review commit: https://reviewboard.mozilla.org/r/227188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227188/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8958257 [details]
Bug 1445073 - Pass XPTInterfaceDirectoryEntry into xptiInterfaceEntry::Create().

https://reviewboard.mozilla.org/r/227188/#review233040

Cleanups are good.

::: xpcom/reflect/xptinfo/xptiInterfaceInfoManager.cpp
(Diff revision 1)
> -                                       iface->mInterfaceDescriptor,
> -                                       typelib);
>      if (!entry)
>          return;
>  
> -    //XXX  We should SetHeader too as part of the validation, no?

Should this comment be preserved, by moving it into the constructor?

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> Should this comment be preserved, by moving it into the constructor?

Looking at the commit history, it looks like SetHeader was a method on some class called "xptiZipItem", which is long gone. I don't think there's any need for the comment.

Comment 4

[Nicholas Nethercote [inactive]]

Oh, you mentioned that in the commit msg. Sorry for the noise.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f01ba44463a
Pass XPTInterfaceDirectoryEntry into xptiInterfaceEntry::Create(). r=njn

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7f01ba44463a