Closed Bug 1445104 Opened 2 years ago Closed 2 years ago

HTMLMediaElement can initialize primitive fields in class declaration instead of in constructor

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(3 files)

Instead of initializing its primitive data fields in its constructor, HTMLMediaElement can just initialize them inline in the class definition. This will make the constructor simpler.
Comment on attachment 8958320 [details]
Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused.

https://reviewboard.mozilla.org/r/227254/#review233088
Attachment #8958320 - Flags: review?(jyavenard) → review+
Comment on attachment 8958319 [details]
Bug 1445104 - Initialize HTMLMediaElement fields in class declaration.

https://reviewboard.mozilla.org/r/227252/#review233090
Attachment #8958319 - Flags: review?(jyavenard) → review+
Comment on attachment 8958321 [details]
Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing.

https://reviewboard.mozilla.org/r/227256/#review233092
Attachment #8958321 - Flags: review?(jyavenard) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e865836987b3
Initialize HTMLMediaElement fields in class declaration. r=jya
https://hg.mozilla.org/integration/autoland/rev/e8a5c35df168
Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya
https://hg.mozilla.org/integration/autoland/rev/d9c664130c22
Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya
You need to log in before you can comment on or make changes to this bug.