1445104 - HTMLMediaElement can initialize primitive fields in class declaration instead of in constructor

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Instead of initializing its primitive data fields in its constructor, HTMLMediaElement can just initialize them inline in the class definition. This will make the constructor simpler.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1445104 - Initialize HTMLMediaElement fields in class declaration.

This makes the constructor simpler.

Review commit: https://reviewboard.mozilla.org/r/227252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227252/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused.

Review commit: https://reviewboard.mozilla.org/r/227254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227254/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing.

Review commit: https://reviewboard.mozilla.org/r/227256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227256/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8958320 [details]
Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused.

https://reviewboard.mozilla.org/r/227254/#review233088

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8958319 [details]
Bug 1445104 - Initialize HTMLMediaElement fields in class declaration.

https://reviewboard.mozilla.org/r/227252/#review233090

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8958321 [details]
Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing.

https://reviewboard.mozilla.org/r/227256/#review233092

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e865836987b3
Initialize HTMLMediaElement fields in class declaration. r=jya
https://hg.mozilla.org/integration/autoland/rev/e8a5c35df168
Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya
https://hg.mozilla.org/integration/autoland/rev/d9c664130c22
Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e865836987b3
https://hg.mozilla.org/mozilla-central/rev/e8a5c35df168
https://hg.mozilla.org/mozilla-central/rev/d9c664130c22