1445140 - Remove nsIDOMDocumentType

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove the XPCOM-ish version of NS_NewDOMDocumentType

MozReview-Commit-ID: 6sEFIfMgqet

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Change NS_NewDOMDocument to take a DocumentType

MozReview-Commit-ID: EGA6OOSbnWV

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Pass a DocumentType to nsIContentSerializer::AppendDoctype

MozReview-Commit-ID: 5UjRSP6MoDI

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove nsIDOMDocumentType members

MozReview-Commit-ID: D9Xwt3qJQDI

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove nsIDOMDocumentType

MozReview-Commit-ID: B6iktNYbWn9

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8958545 [details] [diff] [review]
part 4.  Remove nsIDOMDocumentType members

Review of attachment 8958545 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/DocumentType.cpp
@@ -102,4 @@
>  {
>    aSystemId = mSystemId;
> -
> -  return NS_OK;

I wonder how much CPU time Firefox has collectively burned over time from returning NS_OK values from methods that never fail.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I wonder too, but probably less than from doing the virtual calls involved....

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd6871846be
part 1.  Remove the XPCOM-ish version of NS_NewDOMDocumentType.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a6b2e65e39
part 2.  Change NS_NewDOMDocument to take a DocumentType.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/acf0aa76d956
part 3.  Pass a DocumentType to nsIContentSerializer::AppendDoctype.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/8591715576b9
part 4.  Remove nsIDOMDocumentType members.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/09cca071ae89
part 5.  Remove nsIDOMDocumentType.  r=mystor

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dbd6871846be
https://hg.mozilla.org/mozilla-central/rev/b5a6b2e65e39
https://hg.mozilla.org/mozilla-central/rev/acf0aa76d956
https://hg.mozilla.org/mozilla-central/rev/8591715576b9
https://hg.mozilla.org/mozilla-central/rev/09cca071ae89