1445149 - Eliminate the hardcoded notification ID for the current foreground notification

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement, P3)

Description

[Jan Henning [:JanH]]

Should be possible by passing the NotificationService an additional intent extra with the actual ID of the notification we want to call setForeground() for - that way we'd no longer have to remove and re-add a notification when it is promoted to be our official foreground notification because its ID no longer has to change.

Comment 1

[Jan Henning [:JanH]]

Actually no, when you call setForeground from a service you can only set the numeric ID to be used for the notification, but not the name tag.
So to avoid having to manually remove a notification and then re-adding it with a new ID when turning a notification into our designated foreground notification we'd have to switch at least the NotificationClient to start using IDs instead of tags, at least internally, which I'm not sure is worth the effort right now.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.