1445153 - Remove remaining references to the boxmodel appearing in computed view

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1351685. There were some remaining references to the boxmodel component being displayed in the computedview, in code and comments.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1445153 - Remove remaining references to computedview in boxmodel component;

Review commit: https://reviewboard.mozilla.org/r/227318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227318/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8958372 [details]
Bug 1445153 - Remove remaining references to computedview in boxmodel component;

https://reviewboard.mozilla.org/r/227318/#review233102

Thanks Julian for the clean-up.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the review Patrick! Green try (with an additional commit to fix the current breakage from Bug 1351685)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69aecc1cdef10713fd5e43ac5f9105341dddc87a

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s feab7021625f81e9cc007c7433730ea6e1075556 -d e226de7caa88: rebasing 452133:feab7021625f "Bug 1445153 - Remove remaining references to computedview in boxmodel component;r=pbro" (tip)
merging devtools/client/inspector/inspector.js
merging devtools/client/inspector/test/shared-head.js
warning: conflicts while merging devtools/client/inspector/test/shared-head.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8958372 [details]
Bug 1445153 - Remove remaining references to computedview in boxmodel component;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227318/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86919fbab788
Remove remaining references to computedview in boxmodel component;r=pbro

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/86919fbab788