Closed
Bug 1445183
Opened 7 years ago
Closed 7 years ago
TRR: store TRR telemetry duration correctly
Categories
(Core :: Networking: DNS, enhancement, P1)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bagder, Assigned: bagder)
Details
(Whiteboard: [necko-triaged][trr])
Attachments
(1 file)
It currently stores the duration for each successfully received TRR response, while it should store it for the duration of the response that ultimately gets used.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8958383 [details]
bug 1445183 store TRR duration when the response is used
https://reviewboard.mozilla.org/r/227334/#review233146
::: commit-message-6ff60:1
(Diff revision 1)
> +bug 1445183 store TRR duration telemetry once and for the used response r?valentin
Rephrase this to be clearer.
::: netwerk/dns/nsHostResolver.cpp:1576
(Diff revision 1)
> return LOOKUP_OK;
> }
> // continue
> }
> +
> + if (NS_SUCCEEDED(status) && (rec->mTRRSuccess == 1)) {
Add a comment explaining _why_ we do this.
Attachment #8958383 -
Flags: review?(valentin.gosu) → review+
| Comment hidden (mozreview-request) |
Pushed by daniel@haxx.se:
https://hg.mozilla.org/integration/autoland/rev/4cd3a69dc65b
store TRR duration when the response is used r=valentin
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•