1445248 - Session resumption resumes an old session

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Emmanuel Gil Peyrot]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180313100127

Steps to reproduce:

- Start Firefox, let it resume the session
- Open a few new tabs, close some old ones, do what you’d do in a browsing session.
- Close Firefox
- Reopen Firefox


Actual results:

All of the changes that happened during the session at step 2 vanished, it restored the exact same tabs as step 1.

Additionally, in the browser console I can see that error:
Could not write session state file  Error: _initWorker called too early! Please read the session file from disk first.
Stack trace:
_initWorker/<@resource:///modules/sessionstore/SessionFile.jsm:337:15
_initWorker@resource:///modules/sessionstore/SessionFile.jsm:330:12
_postToWorker@resource:///modules/sessionstore/SessionFile.jsm:354:11
async*write@resource:///modules/sessionstore/SessionFile.jsm:394:19
write@resource:///modules/sessionstore/SessionFile.jsm:66:12
_writeState@resource:///modules/sessionstore/SessionSaver.jsm:357:12
_saveState@resource:///modules/sessionstore/SessionSaver.jsm:295:12
_saveStateAsync@resource:///modules/sessionstore/SessionSaver.jsm:341:5
saveStateAsyncWhenIdle@resource:///modules/sessionstore/SessionSaver.jsm:192:9
requestIdleCallback handler*saveStateAsyncWhenIdle@resource:///modules/sessionstore/SessionSaver.jsm:189:34
requestIdleCallback handler*runDelayed/this._timeoutID<@resource:///modules/sessionstore/SessionSaver.jsm:195:30
notify@resource://gre/modules/Timer.jsm:44:7
 _initWorker/<@resource:///modules/sessionstore/SessionFile.jsm:337:15
_initWorker@resource:///modules/sessionstore/SessionFile.jsm:330:12
_postToWorker@resource:///modules/sessionstore/SessionFile.jsm:354:11
async*write@resource:///modules/sessionstore/SessionFile.jsm:394:19
write@resource:///modules/sessionstore/SessionFile.jsm:66:12
_writeState@resource:///modules/sessionstore/SessionSaver.jsm:357:12
_saveState@resource:///modules/sessionstore/SessionSaver.jsm:295:12
_saveStateAsync@resource:///modules/sessionstore/SessionSaver.jsm:341:5
saveStateAsyncWhenIdle@resource:///modules/sessionstore/SessionSaver.jsm:192:9
requestIdleCallback handler*saveStateAsyncWhenIdle@resource:///modules/sessionstore/SessionSaver.jsm:189:34
requestIdleCallback handler*runDelayed/this._timeoutID<@resource:///modules/sessionstore/SessionSaver.jsm:195:30
notify@resource://gre/modules/Timer.jsm:44:7

This may be the cause of https://bugzilla.mozilla.org/show_bug.cgi?id=1426396


Expected results:

The tabs I opened in step 2 should be restored.

Comment 1

[u554753]

Seems like the bug you're referencing (Bug 1426396) is resolved-invalid by Bug 1330633, so will mark accordingly.

Comment 2

[Dale Harvey (:daleharvey)]

Never say never @ https://dxr.mozilla.org/mozilla-beta/source/browser/components/sessionstore/SessionFile.jsm#326

There isnt enough information here to reproduce and the symptoms sound a lot like the main issue Mike told me should have been fixed recently so closing invalid, if you can still reproduce and give more information on how to reproduce then please reopen, cheers