Closed Bug 1445249 Opened 2 years ago Closed 2 years ago

Make it an error to call IToplevelProtocol::OtherPid() on an unconnected protocol

Categories

(Core :: IPC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

References

Details

Attachments

(3 files)

Currently this happens in a handful of cases, which is causing trouble for bug 1348361.

Currently all the offenders appear to be on Android, and should be straightforward to resolve.

Patch to come shortly :-)
Comment on attachment 8958581 [details]
Bug 1445249 - Part 1 - Remove unused aProcessId parameter when deleting shared memory;

https://reviewboard.mozilla.org/r/227482/#review233306
Attachment #8958581 - Flags: review?(jld) → review+
Comment on attachment 8958582 [details]
Bug 1445249 - Part 2 - avoid calling OtherPid() where it might return an invalid pid on android;

https://reviewboard.mozilla.org/r/227484/#review233308
Attachment #8958582 - Flags: review?(jld) → review+
Comment on attachment 8958583 [details]
Bug 1445249 - Part 3 - Make it an error to call IToplevelProtocol::OtherPid() on an unconnected protocol;

https://reviewboard.mozilla.org/r/227486/#review233310
Attachment #8958583 - Flags: review?(jld) → review+
Keywords: checkin-needed
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d638bedc1a36
Part 1 - Remove unused aProcessId parameter when deleting shared memory; r=jld
https://hg.mozilla.org/integration/autoland/rev/6341884397ca
Part 2 - avoid calling OtherPid() where it might return an invalid pid on android; r=jld
https://hg.mozilla.org/integration/autoland/rev/52977e027427
Part 3 - Make it an error to call IToplevelProtocol::OtherPid() on an unconnected protocol; r=jld
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.