Closed Bug 1445281 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 9998 - Rename bind_hostname to bind_address

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9998 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9998
Details from upstream follow.

Geoffrey Sneddon wrote:
>  Rename bind_hostname to bind_address
>  
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e3992d7141
[wpt PR 9998] - Rename bind_hostname to bind_address, a=testonly
https://hg.mozilla.org/mozilla-central/rev/a9e3992d7141
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
This is a backward incompatible change and the wptserve package on pypi.org hasn't been updated yet.

Geoffrey or James, could one of you prepare or even release a new wptserve version to PyPI? 

Thanks.
Flags: needinfo?(james)
Flags: needinfo?(geoffers+mozilla)
I can't; only James has access. I also don't know how much sense it makes to keep PyPI up-to-date?
Flags: needinfo?(geoffers+mozilla)
Are you actually using this out of tree? We can do a new release, but I don't think we should until the multihreading issues with the Config object are sorted out.
Flags: needinfo?(james)
(In reply to James Graham [:jgraham] from comment #16)
> Are you actually using this out of tree? We can do a new release, but I
> don't think we should until the multihreading issues with the Config object
> are sorted out.

I did that by accident when I setup a new virtualenv for marionette testing from mozilla-central. Running the `python setup.py develop` step from testing/marionette/harness, will not install the in-tree wptserve but the version from PyPI. Only for packaged tests it's working.
You need to log in before you can comment on or make changes to this bug.