Closed Bug 1445288 Opened 6 years ago Closed 6 years ago

Intermittent gfx/layers/apz/test/mochitest/test_key_scroll.html | uncaught exception - TypeError: lastPaint is undefined at checkHasAsyncKeyScrolled@http://mochi.test:8888/tests/gfx/layers/apz/test/mochitest/helper_key_scroll.html:97:11

Categories

(Core :: Panning and Zooming, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kats)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

The screenshot shows a distinct lack of firefox windows. I expect that this will be the only occurrence of this error, and we'll close this bug as WFM in a month or whatever.
Looks like I was wrong... bug 1445327 is an instance of this on linux.
Weird that this seems to have come out of nowhere (no obvious regressing changeset) and yet is so frequent. I looked at the test and it just does a waitForFocus before starting to read compositor paints, so it could use some robustification. I'll turn it into a group_keyboard test similar to our other tests.
Assignee: nobody → bugmail
That try push doesn't seem to have actually run the test because it was the first try push after a m-c merge so the verify job picked up a slew of modified tests, and then seems to have run the browser-chrome ones only. Or something to that effect.

Hopefully this will be better: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cb7a115dcf975f8315c9353b8b390f5f6b200a6
Weird, this went away by itself (the occurrences seem to stop around the 16th of March). Still, the patch is worth landing I think.
Comment on attachment 8959651 [details]
Bug 1445288 - Turn test_key_scroll into a group test and robustify it a bit.

https://reviewboard.mozilla.org/r/228462/#review234878

::: gfx/layers/apz/test/mochitest/helper_key_scroll.html:13
(Diff revision 1)
>    <title>Async key scrolling test, helper page</title>
>    <script type="application/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
>    <script type="application/javascript" src="/tests/SimpleTest/paint_listener.js"></script>
>    <script type="application/javascript" src="apz_test_utils.js"></script>
>    <script type="application/javascript">
> -    var SimpleTest = window.opener.SimpleTest;
> +    waitUntilApzStable().then(runTests);

Let's stick to the established pattern of having this near the bottom of the script.
Attachment #8959651 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b02291cd4e6e
Turn test_key_scroll into a group test and robustify it a bit. r=botond
https://hg.mozilla.org/mozilla-central/rev/b02291cd4e6e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: