Closed
Bug 1445288
Opened 6 years ago
Closed 6 years ago
Intermittent gfx/layers/apz/test/mochitest/test_key_scroll.html | uncaught exception - TypeError: lastPaint is undefined at checkHasAsyncKeyScrolled@http://mochi.test:8888/tests/gfx/layers/apz/test/mochitest/helper_key_scroll.html:97:11
Categories
(Core :: Panning and Zooming, defect, P5)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: kats)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: nbeleuzu [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=167674494&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/FQe1lPFeTc6Mm-2xkIPA_A/runs/0/artifacts/public/logs/live_backing.log
Assignee | ||
Comment 1•6 years ago
|
||
The screenshot shows a distinct lack of firefox windows. I expect that this will be the only occurrence of this error, and we'll close this bug as WFM in a month or whatever.
Assignee | ||
Comment 3•6 years ago
|
||
Looks like I was wrong... bug 1445327 is an instance of this on linux.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•6 years ago
|
||
Weird that this seems to have come out of nowhere (no obvious regressing changeset) and yet is so frequent. I looked at the test and it just does a waitForFocus before starting to read compositor paints, so it could use some robustification. I'll turn it into a group_keyboard test similar to our other tests.
Assignee: nobody → bugmail
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ed977f59d59de6f7e561853de6f7eeaad948eac
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•6 years ago
|
||
That try push doesn't seem to have actually run the test because it was the first try push after a m-c merge so the verify job picked up a slew of modified tests, and then seems to have run the browser-chrome ones only. Or something to that effect. Hopefully this will be better: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cb7a115dcf975f8315c9353b8b390f5f6b200a6
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 10•6 years ago
|
||
Weird, this went away by itself (the occurrences seem to stop around the 16th of March). Still, the patch is worth landing I think.
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8959651 [details] Bug 1445288 - Turn test_key_scroll into a group test and robustify it a bit. https://reviewboard.mozilla.org/r/228462/#review234878 ::: gfx/layers/apz/test/mochitest/helper_key_scroll.html:13 (Diff revision 1) > <title>Async key scrolling test, helper page</title> > <script type="application/javascript" src="/tests/SimpleTest/EventUtils.js"></script> > <script type="application/javascript" src="/tests/SimpleTest/paint_listener.js"></script> > <script type="application/javascript" src="apz_test_utils.js"></script> > <script type="application/javascript"> > - var SimpleTest = window.opener.SimpleTest; > + waitUntilApzStable().then(runTests); Let's stick to the established pattern of having this near the bottom of the script.
Attachment #8959651 -
Flags: review?(botond) → review+
Comment hidden (mozreview-request) |
Comment 13•6 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b02291cd4e6e Turn test_key_scroll into a group test and robustify it a bit. r=botond
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b02291cd4e6e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•