Closed Bug 1445332 Opened 2 years ago Closed Last year

Update our copy of Speedometer to pick up geometric mean reporting changes

Categories

(Testing :: Talos, enhancement)

Version 3
enhancement
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: dmajor, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch geomeanSplinter Review
Assignee: nobody → dmajor
Attachment #8958516 - Flags: review?(ehsan)
Comment on attachment 8958516 [details] [diff] [review]
geomean

Review of attachment 8958516 [details] [diff] [review]:
-----------------------------------------------------------------

I am open to ideas of how to update the source easier without affecting our small set of modifications.

::: third_party/webkit/PerformanceTests/Speedometer/resources/benchmark-report.js
@@ +1,4 @@
>  // This file can be customized to report results as needed.
>  
>  (function () {
> +    if (!window.testRunner && location.search != '?webkit' && location.hash != '#webkit')

this removes our hack to get automated running tests in talos

@@ +75,5 @@
>                  fullNames.push(fullName);
>  
> +            for (var i = 0; i < fullNames.length; i++) {
> +                var values = measuredValuesByFullName[fullNames[i]];
> +                PerfTestRunner.reportValues(createTest(fullNames[i], values.aggregator, i + 1 == fullNames.length), values);

this removed our code for tpRecordTime which is how we record the results.
Attachment #8958516 - Flags: review?(ehsan) → review-
Oh sorry, I didn't know that the Talos modifications were applied on top of these files! I thought they were elsewhere.
I also didn't realize that Talos already calulcates a geometric mean externally: https://searchfox.org/mozilla-central/source/testing/talos/talos/output.py#242
Unassigning because comment 4 made me not really care anymore.
Assignee: dmajor → nobody
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.