1445345 - Stop including <windows.h> in IPDL generated headers

Status: RESOLVED WONTFIX

(Core :: IPC, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

windows.h is an amazing and wonderful header which will break many different source files if it is included in them. Unfortunately, on windows we include this header in all of our IPDL generated header files transitively through various chromium IPC headers.

It'd be nice to:
a) Not do that,
b) Make sure we never do that again.

Hence, this bug.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Here's the try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=deae126e8f9d8d55743f6d86075f08e992a743c5

I haven't actually built this patch on a windows machine yet, so I'm expecting a few failures, then I'll post the final patches.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 1: Avoid including windows.h in lock_impl.h

MozReview-Commit-ID: FsaBQCr5vgg

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 2: Avoid including windows.h in process.h

MozReview-Commit-ID: AAWryabeQIt

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 3: Remove unused FILETIME functions from time.h to avoid including windows.h

MozReview-Commit-ID: FZDFtL9hgSr

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 5: Avoid including windows.h in platform_thread.h

MozReview-Commit-ID: 2MUB7iDofkS

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 6: Avoid depending on message_pump_win.h for MessageLoopForIO's declaration

MozReview-Commit-ID: 6pWbOM4cDB3

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 7: Remove some unused windows-only methods from MessageLoop to un-include message_pump_win.h

MozReview-Commit-ID: 6jo3iaXxAtp

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 8: Avoid including windows.h in process_util.h

MozReview-Commit-ID: IurzPC1c3ar

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 9: Test that IPDL headers don't include windows.h in a somewhat cross-platform manner

MozReview-Commit-ID: 3KYdw5QGDur

Comment 11

[Nika Layzell [:nika] (ni? for response)]

I ended up taking a bit of a different approach here with bug 1448426. 

If we decide to land that patch, I think I'm going to WONTFIX this one.

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Can this be marked as WONTFIX?

Comment 13

[Nika Layzell [:nika] (ni? for response)]

Yup! - thanks for the reminder :-)