1445354 - Remove nsIDOMText

Status: RESOLVED DUPLICATE of bug 1433566

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Adrian Wielgosik [:adrian17]]

There already is a bug for this interface (bug 1433566), with a patch.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ah, I missed that...  Thought I had checked.  :(

(Of course I mostly-wrote patches before filing...)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add a non-virtual nsINode::IsText()

MozReview-Commit-ID: Ik5hGubUDqX

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove use of nsIDOMText from JS

MozReview-Commit-ID: LtAhn223y0s

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove nsIDOMText::SplitText

MozReview-Commit-ID: 1jghu75LKDw

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove unused aCloneAfterOriginal arg of nsGenericDOMDataNode::SplitData

MozReview-Commit-ID: RUJSiOt7Av

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Convert nsGenericDOMDataNode::SplitData to webidl calling conventions

MozReview-Commit-ID: 255TGkYJd4q

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Inline SplitData into its one caller

This is mostly a straightforward copy.  The only change is what happens with
the return value of CloneDataNode: it's cast to Text directly, and the
null-check is replaced by an assert.

MozReview-Commit-ID: B5rnhEOneZn

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. Remove nsIDOMText::GetWholeText

MozReview-Commit-ID: I8ZB56a82ze

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 8. Convert nsGenericDOMDataNode::GetWholeText to webidl-style calling convention

MozReview-Commit-ID: 1ueFgT3ANRS

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: part 9. Move GetWholeText over into Text.cpp

Just code motion, no changes.

MozReview-Commit-ID: 98LkyuU4mya

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: part 10. Stop using nsIDOMText in GetWholeText

MozReview-Commit-ID: 4M4q41mEpgb

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: part 11. Stop using nsIDOMText in range code

MozReview-Commit-ID: 2EY6w5YlLCH

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Stop using nsIDOMText in layout

MozReview-Commit-ID: KliYtj5U8jK

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: part 13. Remove nsIDOMText

MozReview-Commit-ID: DvaZ96j5exf