1445388 - Smartphone icon should be sized to be pixel snapped

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect, P2)

Description

[Ryan Feeley [:rfeeley]]

Attachment: IMG_5561.png

Sizing issue? Look at that laptop. Every right angle is crisp and sharp but the phone only has a hard edge on less than half of the right angles.

Comment 1

[:garvan]

taking a quick look at the source for this...

Comment 2

[:garvan]

Attachment: Icons at 1:1 pixel size

Comment 3

[:garvan]

Comment on attachment 8960305 [details]
Icons at 1:1 pixel size

They are a bit smaller at 1:1 size (they aren't the full row height), but I think it looks ok, 
wdyt?

Comment 4

[Ryan Feeley [:rfeeley]]

This is something you'll only be able to notice when your monitor is at default scale (and even then, you need to zoom in or double it without interpolation). Still it's table stakes for icons. Right angles should be on the pixel so look supremely crisp.

Comment 5

[:garvan]

Attachment: Pull request

Comment 6

[:garvan]

Landed on master

Comment 7

[Ryan Feeley [:rfeeley]]

Comment on attachment 8960305 [details]
Icons at 1:1 pixel size

Let's review in person on my giant HiDPI large print screen. It's lower ppi than a Mac laptop and easier to tell when an icon’s lines are not snapped to the pixel. In this case, the smartphone vertical and horizontal lines are still not on the pixel. Anti-aliasing is fine for rounded corners, but never a goal for vertical or horizontal lines.