Closed
Bug 1445389
Opened 7 years ago
Closed 7 years ago
Annotate int flags with IntDef
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
Details
Attachments
(1 file)
|
23.99 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
IntDef annotations prevent assignment of invalid values and help with IDE auto-completion.
|
Assignee | |
Comment 1•7 years ago
|
||
I think the default CLASS retention policy is what we want to enable IDE support for GV consumers.
Attachment #8958568 -
Flags: review?(nchen)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8958568 [details] [diff] [review]
0001-Bug-1445389-1.0-Add-IntDef-annotations-to-int-flags..patch
Jim is on PTO.
Attachment #8958568 -
Flags: review?(nchen) → review?(snorp)
Comment on attachment 8958568 [details] [diff] [review]
0001-Bug-1445389-1.0-Add-IntDef-annotations-to-int-flags..patch
Review of attachment 8958568 [details] [diff] [review]:
-----------------------------------------------------------------
I would like to hide these in docs, but we probably need @hide for that, which requires us to use a different doclet.
Attachment #8958568 -
Flags: review?(snorp) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c04449f79a3
[1.0] Add IntDef annotations to int flags. r=snorp
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•7 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 61 → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•