1445455 - StatusPanel cannot show the same anchor link twice in a row

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Visit https://www.mozilla.org/en-US/
2) Scroll down to the bottom and choose a link to hover
3) Hover the link so that the StatusPanel appears in the top-left corner of the screen
4) Move your mouse away from the link (but not over another link) so that the StatusPanel showing the URL hides
5) Hover the _same_ link again, like in step 3

ER:

The StatusPanel should become visible again showing the same link as before.

AR:

The StatusPanel does not appear again.

I highly suspect this is fallout from bug 1444891, but will do a local backout to confirm.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

We should probably add a test for this once it gets fixed, fwiw.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Local backout has confirmed that bug 1444891 is the regressor.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I think I've figured this out. Patch and test coming up.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1445455 - StatusPanel needs to update label even when the label text has not changed.

Review commit: https://reviewboard.mozilla.org/r/227532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227532/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1445455 - Test that it's possible to show the same StatusPanel value twice in a row.

Review commit: https://reviewboard.mozilla.org/r/227556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227556/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8958625 [details]
Bug 1445455 - StatusPanel needs to update label even when the label text has not changed.

https://reviewboard.mozilla.org/r/227532/#review233388

::: browser/base/content/tabbrowser.js:4618
(Diff revision 1)
> +  // We don't clear the text from the label when setting it as inactive
> +  // to avoid the panel snapping to a short width as it fades away. So
> +  // when clearing the StatusPanel, we actually keep the last URL in the
> +  // label. We still need to know what the last update was to determine
> +  // whether or not to show the panel again, so we stash a copy here.
> +  _lastStatusText: "",

This comment confused me quite a bit, because if the panel keeps the last URL anyway, why bother remembering it a second time? The catch is that 'text' in update() can be empty...

::: browser/base/content/tabbrowser.js:4634
(Diff revision 1)
>        if ((text = XULBrowserWindow[type])) {
>          break;
>        }
>      }
>  
> -    if (this._labelElement.value != text) {
> +    if (this._lastStatusText != text) {

How about:

if (this._labelElement.value != text ||
    text && !this.isVisible) {

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8958645 [details]
Bug 1445455 - Test that it's possible to show the same StatusPanel value twice in a row.

https://reviewboard.mozilla.org/r/227556/#review233390

Thanks!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8958625 [details]
Bug 1445455 - StatusPanel needs to update label even when the label text has not changed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227532/diff/1-2/

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8958645 [details]
Bug 1445455 - Test that it's possible to show the same StatusPanel value twice in a row.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227556/diff/1-2/

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8958625 [details]
Bug 1445455 - StatusPanel needs to update label even when the label text has not changed.

https://reviewboard.mozilla.org/r/227532/#review233388

> How about:
> 
> if (this._labelElement.value != text ||
>     text && !this.isVisible) {

Yeah, I like that better, thanks.

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8958625 [details]
Bug 1445455 - StatusPanel needs to update label even when the label text has not changed.

https://reviewboard.mozilla.org/r/227532/#review233482

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39af208c6af0
StatusPanel needs to update label even when the label text has not changed. r=dao
https://hg.mozilla.org/integration/autoland/rev/c1126af7196b
Test that it's possible to show the same StatusPanel value twice in a row. r=dao

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/39af208c6af0
https://hg.mozilla.org/mozilla-central/rev/c1126af7196b

Comment 14

[Sajedul Islam]

I have reproduced this bug with Nightly 61.0a1 (2018-03-13) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180317100337
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180314]

Comment 15

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-03-13) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly!

Build   ID    20180317111042
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Comment 16

[Sajedul Islam]

As par comment 14 & comment 15 i am marking this bug as verified fixed.