Closed Bug 1445478 Opened 2 years ago Closed 2 years ago

Make dom/events/test/pointerevents/test_bug1414336.html not racy

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1439875 trickles it so that it's more frequently intermittent in headless opt builds (oh well).

I managed to get a trace under rr and the first event wasn't dispatched because the point pointed to the body background, which indicates that probably the iframe moved in between the synthesizeFoo messages came and went.

This follows kats' advice and moves it to gfx/layers/apz/test/mochitest/test_group_pointerevents.html to make the test not racy.
Comment on attachment 8958646 [details]
Bug 1445478: Make pointerevents/test_bug1414336.html more reliable.

https://reviewboard.mozilla.org/r/227560/#review233360

::: gfx/layers/apz/test/mochitest/helper_bug1414336.html:84
(Diff revision 1)
> +    event.preventDefault();
> +  }, { once: true });
> +
> +  target0.addEventListener("pointerup", (event) => {
> +    ok(target0_events.length == 0, " should receive " + target0_events + " on target0");
> +    SimpleTest.finish();

Remove this SimpleTest.finish() call as well
Attachment #8958646 - Flags: review?(bugmail) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a749119ba1e4
Make pointerevents/test_bug1414336.html more reliable. r=kats
https://hg.mozilla.org/mozilla-central/rev/a749119ba1e4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.