1445504 - "JavaScript Guide" tutorial does not include "Using Promises" page

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: JavaScript, defect, P5)

Description

[mcguire]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

The page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises does not appear in the left-hand sidebar under "JavaScript Guide" (or anywhere else, for that matter). It is linked from the Promise object page (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise).

Comment 1

[Julien G]

Hello,

Thanks for reporting this issue, the link indeed is missing... This sidebar is generated by a "macro" and its code lives on https://github.com/mdn/kumascript/blob/master/macros/JsSidebar.ejs

As you can see from L405 (https://github.com/mdn/kumascript/blob/master/macros/JsSidebar.ejs#L405 ) there is a bunch of links for the JavaScript Guide.

Do you feel confident to make a PR and fix this once and for all? :)
If not, that's no problem, I'll help.

Comment 2

[Chris Mills [:cmills]]

I've decided to jump in and fix this ;-)

I've submitted a PR to fix the sidebar:
https://github.com/mdn/kumascript/pull/658

I've added to promises guide to the main guide page:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide

I've added the nav menu to the promises guide itself:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises

Comment 3

[rgucluer]

Hi,
Problem continues:

"Using promises" link
does not appear on some pages:

Thanks for the link to the source code. I will examine it.

Link does not exist in the following pages:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Introduction
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Loops_and_iteration
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Functions
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Numbers_and_dates
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Text_formatting
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Keyed_collections
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Details_of_the_Object_Model
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_generators
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Meta_programming

Link exists in the following pages:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_Types
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Control_flow_and_error_handling
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Indexed_collections
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Working_with_Objects

Comment 4

[Chris Mills [:cmills]]

(In reply to rgucluer from comment #3)
> Hi,
> Problem continues:
> 
> "Using promises" link
> does not appear on some pages:

This is because the static pages had not been regenerated yet. I loaded the pages and did a force refresh (Shift + Refresh) on each page, and the "Using promises" link appears on all of them now.

Comment 5

[rgucluer]

Hi Chris,
  Thanks for the reply. Yes, all links are working now.