Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P5
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: emk, Assigned: emk)

Tracking

Trunk
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
Currently, if the page takes long time to load, the character encoding menu will not be disabled on loading.
I agree that this is a bug in principle, but it's probably not worth fixing in the sense that it would probably be more useful to focus on detecting unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing if character encoding menu usage drops enough to remove the menu.
Priority: -- → P5
Assignee

Comment 2

Last year
(In reply to Henri Sivonen (:hsivonen) from comment #1)
> I agree that this is a bug in principle, but it's probably not worth fixing
> in the sense that it would probably be more useful to focus on detecting
> unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing
> if character encoding menu usage drops enough to remove the menu.

Please do not. I'm using the encoding menu almost everyday to view Chinese text files encoded in GBK. Detecting UTF-8 does not help.
Assignee

Comment 4

Last year
I wrote a patch, after all.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

Comment 5

Last year
mozreview-review
Comment on attachment 8965483 [details]
Bug 1445541 - Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found.

https://reviewboard.mozilla.org/r/234244/#review239984

Thank you.
Attachment #8965483 - Flags: review?(hsivonen) → review+

Comment 6

Last year
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/effaf62f3423
Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found. r=hsivonen

Comment 7

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/effaf62f3423
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.