1445541 - Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement, P5)

Description

[Masatoshi Kimura [:emk]]

Currently, if the page takes long time to load, the character encoding menu will not be disabled on loading.

Comment 1

[Henri Sivonen (:hsivonen)]

I agree that this is a bug in principle, but it's probably not worth fixing in the sense that it would probably be more useful to focus on detecting unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing if character encoding menu usage drops enough to remove the menu.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Henri Sivonen (:hsivonen) from comment #1)
> I agree that this is a bug in principle, but it's probably not worth fixing
> in the sense that it would probably be more useful to focus on detecting
> unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing
> if character encoding menu usage drops enough to remove the menu.

Please do not. I'm using the encoding menu almost everyday to view Chinese text files encoded in GBK. Detecting UTF-8 does not help.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1445541 - Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found.

Review commit: https://reviewboard.mozilla.org/r/234244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234244/

Comment 4

[Masatoshi Kimura [:emk]]

I wrote a patch, after all.

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8965483 [details]
Bug 1445541 - Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found.

https://reviewboard.mozilla.org/r/234244/#review239984

Thank you.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/effaf62f3423
Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found. r=hsivonen

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/effaf62f3423