Closed Bug 1445541 Opened 4 years ago Closed 4 years ago

Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found

Categories

(Core :: DOM: HTML Parser, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

Currently, if the page takes long time to load, the character encoding menu will not be disabled on loading.
I agree that this is a bug in principle, but it's probably not worth fixing in the sense that it would probably be more useful to focus on detecting unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing if character encoding menu usage drops enough to remove the menu.
Priority: -- → P5
(In reply to Henri Sivonen (:hsivonen) from comment #1)
> I agree that this is a bug in principle, but it's probably not worth fixing
> in the sense that it would probably be more useful to focus on detecting
> unlabeled UTF-8 in text/plain and text/html from file: URL and then seeing
> if character encoding menu usage drops enough to remove the menu.

Please do not. I'm using the encoding menu almost everyday to view Chinese text files encoded in GBK. Detecting UTF-8 does not help.
I wrote a patch, after all.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 8965483 [details]
Bug 1445541 - Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found.

https://reviewboard.mozilla.org/r/234244/#review239984

Thank you.
Attachment #8965483 - Flags: review?(hsivonen) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/effaf62f3423
Enable the character encoding menu when the document is decoded as UTF-8 and an error is found, instead of disabling it when no errors are found. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/effaf62f3423
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.