1445586 - Passcode screen does not refresh after disabling Passcode for Logins

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Simon Basca [:SimonB]]

Build: 11.0 (9593)
Device: iPad Air 2
iOS: 11.2.5

Steps to reproduce:
1. Go to Settings -> Passcode For Logins
2. Tap "Turn Passcode On" and set a passcode
3. Tap on "Require Passcode"
4. Type the correct passcode
5. Tap on "Passcode For Logins" to go back to the previous screen
6. Tap "Turn Passcode Off" and type the correct passcode

Actual results:
- All the options are still active although the passcode has been disabled. After tapping back to "Settings" and again tapping on "Passcode For Logins" the screen refreshes and the options become inactive. 

Expected results:
- The Passcode options should become inactive after disabling the passcode.  

See video here: 
- https://www.youtube.com/watch?v=RAuYNsBA9ic

Comment 1

[Justin D'Arcangelo [:justindarc]]

This appears to be iPad-only. Weird.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Throwing this one back in. No idea what is going wrong here. It seems for some reason that `NotificationCenter` is not receiving the notification that the passcode was removed.

Comment 3

[:garvan]

AuthenticationSettingsViewController.viewDidDisappear() is never called when the passcode setting controller shows the "Require Passcode" sub-VC, however AuthenticationSettingsViewController.viewDidAppear() *is* called when that sub-VC is dismissed.

If the notification observer is re-added in AuthenticationSettingsViewController.viewDidAppear() the bug goes away (and I confirmed by checking `NotificationCenter.default.debugDescription` that the observer has been deregistered.

2 puzzles:
- why is viewDidAppear called without seeing viewDidDisappear ?
- where is the notification observer removed ?

Comment 4

[:garvan]

nvm, viewDidDisappear is called, and the parent class is removing the observers

Comment 5

[:garvan]

Attachment: Pull request

Comment 6

[:garvan]

landed on master