1445605 - Make GetCSSFloatValue use GetPropertyValue instead of GetPropertyCSSValue.

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

We only use it for properties that return pixels anyway, so we can use it without much problem.

This also fixes bug 1428974.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Make GetCSSFloatValue use GetPropertyValue instead of GetPropertyCSSValue.

We only use it for properties that return pixels anyway, so we can use it without much problem.
    
This also fixes bug 1428974.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8958777 [details] [diff] [review]
Make GetCSSFloatValue use GetPropertyValue instead of GetPropertyCSSValue.

Review of attachment 8958777 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/HTMLAnonymousNodeEditor.cpp
@@ +62,4 @@
>      return 0;
>    }
>  
> +  MOZ_ASSERT(value.Length() > 2, "Should always have a `px` suffix");

So, does nsComputedDOMStyle::GetPropertyValue() always return the value as CSS pixels, i.e., even if border-width is specified with "thin"/"medium"/"thick"? Your commit message and this bug report is really unclear to me. Please explain more for making any other developers who are not familiar with CSS implementation can understand easier.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8958777 [details] [diff] [review]
Make GetCSSFloatValue use GetPropertyValue instead of GetPropertyCSSValue.

Yes, see bug 1428974, which was filed because we don't need to handle those. Per spec borders are resolved to pixels.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

You can see this easily with:

  document.body.style.border = "1px solid thin"; getComputedStyle(document.body).getPropertyValue("border")

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Err, getPropertyValue("border-left-width"); I mean

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, could you explain that getPropertyValue() always returns pixels in the commit message and comment in HTMLAnonymousNodeEditor.cpp? Without the explanation, some developers may start to investigate if it's buggy like me.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: With comments.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8959109 [details] [diff] [review]
With comments.

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b2dbf5775c9
Make GetCSSFloatValue use GetPropertyValue instead of GetPropertyCSSValue. r=masayuki

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7b2dbf5775c9