Closed
Bug 1445610
Opened 6 years ago
Closed 6 years ago
Clean up Value.h enums a bit
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
5.03 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
JS_ENUM_HEADER and JS_ENUM_FOOTER are only needed to work around a GCC bug with JSValueTag nowadays. We can use plain enums for JSValueType, JSValueShiftedTag and when we're using Clang.
Attachment #8958781 -
Flags: review?(jwalden+bmo)
|
||
Updated•6 years ago
|
Attachment #8958781 -
Flags: review?(jwalden+bmo) → review+
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb94742032b5 Clean up some enums in Value.h. r=jwalden
|
||
Comment 2•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bb94742032b5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•