Closed
Bug 1445615
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10027 - [css-grid] Add support for calc() in gutter properties
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10027 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10027 Details from upstream follow. Manuel Rego Casasnovas wrote: > [css-grid] Add support for calc() in gutter properties > > There was a crash in debug if you use calc() > mixing fixed and percentage values due to the wrong DCHECK > in GapLength constructor. The patch fixes this assert. > > In addition LayoutGrid::GridGap() was also wrong and didn't consider > calc() either. The fix is again easy just using the proper check. > > Regarding testing, the parsing tests have been updated to include > this combination of fixed and percentage values in calc(). > At the same time, the patch actually uses "grid-" prefixed properties > in the tests that were supposed to test those. > Last, two new tests are added to verify the proper behavior of calc() > with mixed values on a grid layout container. > > BUG=816300 > TEST=external/wpt/css/css-align/gaps/column-gap-parsing-001.html > TEST=external/wpt/css/css-align/gaps/gap-parsing-001.html > TEST=external/wpt/css/css-align/gaps/grid-column-gap-parsing-001.html > TEST=external/wpt/css/css-align/gaps/grid-gap-parsing-001.html > TEST=external/wpt/css/css-align/gaps/grid-row-gap-parsing-001.html > TEST=external/wpt/css/css-align/gaps/row-gap-parsing-001.html > TEST=external/wpt/css/css-grid/alignment/grid-gutters-011.html > TEST=external/wpt/css/css-grid/alignment/grid-gutters-012.html > > Change-Id: I4c9fe6b2525a253c6bb00cbda727c2bf1ae6e90b > Reviewed-on: https://chromium-review.googlesource.com/962148 > WPT-Export-Revision: 045c9118cbc4f9b09eb8c136c80776192321749b
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=99365b000ac7280b86d0fb46fb87c662d863ad72
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f462ec3faf1b30d78b05343b7d49cc1f7b97cd4
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b22e33eaf96c [wpt PR 10027] - [css-grid] Add support for calc() in gutter properties, a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b22e33eaf96c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b22e33eaf96c
You need to log in
before you can comment on or make changes to this bug.
Description
•