1445616 - bustage in widget/windows/nsNativeDragSource.cpp when Gecko 61 merges to Beta on 2018-04-26

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=742ee48b8f7605fe337ebeca93bd853fa8285c4b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=167912446

Triggered by the changes in bug 1444686, it seems (haven't bisected).

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=167912446&repo=try

12:32:26     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/widget/windows'
12:32:26     INFO -  z:/build/build/src/sccache2/sccache.exe z:/build/build/src/vs2017_15.6.0/VC/bin/Hostx64/x86/cl.exe -FoUnified_cpp_widget_windows2.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_UNICODE -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/widget/windows -Iz:/build/build/src/obj-firefox/widget/windows -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/layout/generic -Iz:/build/build/src/layout/xul -Iz:/build/build/src/toolkit/xre -Iz:/build/build/src/widget -Iz:/build/build/src/widget/headless -Iz:/build/build/src/xpcom/base -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O1 -Oi -Oy- -Iz:/build/build/src/obj-firefox/dist/include/cairo -GL -deps.deps/Unified_cpp_widget_windows2.obj.pp    z:/build/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows2.cpp
12:32:26     INFO -  Unified_cpp_widget_windows2.cpp
12:32:26     INFO -  z:/build/build/src/widget/windows/nsNativeDragSource.cpp(94): error C2027: use of undefined type 'mozilla::dom::DataTransfer'
12:32:26     INFO -  z:\build\build\src\obj-firefox\dist\include\nsIDragService.h(43): note: see declaration of 'mozilla::dom::DataTransfer'
12:32:26     INFO -  z:/build/build/src/widget/windows/nsNativeDragSource.cpp(94): error C2039: 'GetMozCursor': is not a member of 'RefPtr<mozilla::dom::DataTransfer>'
12:32:26     INFO -  z:\build\build\src\widget\windows\nsNativeDragSource.h(61): note: see declaration of 'RefPtr<mozilla::dom::DataTransfer>'
12:32:26     INFO -  z:/build/build/src/config/rules.mk:1045: recipe for target 'Unified_cpp_widget_windows2.obj' failed
12:32:26     INFO -  mozmake.EXE[5]: *** [Unified_cpp_widget_windows2.obj] Error 2

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  Must be unified builds making this compile on m-c...

Fix coming up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28123ccf808847b2a185d871a76928b9024d129f running.  I am quite sure it will be green.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Add missing DataTransfer include to fix compilation on Windows

MozReview-Commit-ID: KT44TCYInnO

Comment 4

[Boris Zbarsky [:bzbarsky]]

OK.  Build is still red, but with link errors about unresolved externals in skia, so not related to this issue.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa756d9b7c8f
Add missing DataTransfer include to fix compilation on Windows. r=mystor

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fa756d9b7c8f

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c95d805c642d21e5e677b6631ec6c9efa4911517&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable