Closed
Bug 1445658
Opened 6 years ago
Closed 6 years ago
[MIPS32] Implement BaseCompiler::pop2xI64ForMulI64
Categories
(Core :: JavaScript Engine: JIT, enhancement, P5)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → dragan.mladjenovic
Attachment #8958847 -
Flags: review?(lhansen)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8958847 [details] [diff] [review] bug1445658.patch Review of attachment 8958847 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/wasm/WasmBaselineCompile.cpp @@ +4691,5 @@ > *r0 = popI64ToSpecific(specific.edx_eax); > *temp = needI32(); > #elif defined(JS_CODEGEN_MIPS64) > pop2xI64(r0, r1); > +#elif defined(JS_CODEGEN_MIPS32) You can land this if you like, but I'm probably happiest if you fold it into the ARM case that follows just after. (I see I have a little cleanup to do in that regard for some of the other methods around here.)
Attachment #8958847 -
Flags: review?(lhansen) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Updated•6 years ago
|
Priority: -- → P5
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/93307191f758 [MIPS32] Implement BaseCompiler::pop2xI64ForMulI64; r=lth
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/93307191f758
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•